summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordtucker@openbsd.org <dtucker@openbsd.org>2023-03-29 00:59:08 +0000
committerDarren Tucker <dtucker@dtucker.net>2023-03-29 12:22:33 +1100
commitc3da05d95922f5550bcc7815e799474d6a160175 (patch)
treec3210a71bfe6c53604aae185133563fcfb26ddf1
parent13ae327eae598b1043e5ec30e4b170edb3c898a5 (diff)
downloadopenssh-git-c3da05d95922f5550bcc7815e799474d6a160175.tar.gz
upstream: Plug potential mem leak in process_put.
It allocates abs_dst inside a loop but only frees it on exit, so free inside the loop if necessary. Coverity CID 291837, ok djm@ OpenBSD-Commit-ID: a01616503a185519b16f00dde25d34ceaf4ae1a3
-rw-r--r--sftp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sftp.c b/sftp.c
index 6c5aab7a..07b46c7f 100644
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.230 2023/03/28 07:44:32 dtucker Exp $ */
+/* $OpenBSD: sftp.c,v 1.231 2023/03/29 00:59:08 dtucker Exp $ */
/*
* Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
*
@@ -769,6 +769,8 @@ process_put(struct sftp_conn *conn, const char *src, const char *dst,
goto out;
}
+ free(abs_dst);
+ abs_dst = NULL;
if (g.gl_matchc == 1 && tmp_dst) {
/* If directory specified, append filename */
if (dst_is_dir)