summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDamien Miller <djm@mindrot.org>2023-03-31 14:17:22 +1100
committerDamien Miller <djm@mindrot.org>2023-03-31 14:17:22 +1100
commita4c1c2513e36f111eeaa1322c510067930e5e51e (patch)
treea0045e9897ac7439ffe0cf77b05101a3cba8f5d5
parent34ee842cdd981a759fe8f0d4a37521f9a1c63170 (diff)
downloadopenssh-git-a4c1c2513e36f111eeaa1322c510067930e5e51e.tar.gz
don't call connect() on negative socket
Coverity CID 405037
-rw-r--r--channels.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/channels.c b/channels.c
index d9f59f46..ffaf8972 100644
--- a/channels.c
+++ b/channels.c
@@ -5045,8 +5045,10 @@ connect_local_xsocket_path(const char *pathname)
struct sockaddr_un addr;
sock = socket(AF_UNIX, SOCK_STREAM, 0);
- if (sock == -1)
+ if (sock == -1) {
error("socket: %.100s", strerror(errno));
+ return -1;
+ }
memset(&addr, 0, sizeof(addr));
addr.sun_family = AF_UNIX;
strlcpy(addr.sun_path, pathname, sizeof addr.sun_path);