diff options
| author | Denis Kenzior <denkenz@gmail.com> | 2022-09-08 10:19:09 -0500 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2022-09-08 10:19:09 -0500 |
| commit | dca99b7428a6ae6f25544cc70a7057838fd609e6 (patch) | |
| tree | d1aa47d06de31d08f3c1aa5bb3aca5e82f5d1703 | |
| parent | 1c72e727c81ad7a2ad3548f610cf27a6c618f347 (diff) | |
| download | ofono-dca99b7428a6ae6f25544cc70a7057838fd609e6.tar.gz | |
gemaltomodem: Fix GCC warning
CC drivers/gemaltomodem/gprs-context.o
drivers/gemaltomodem/gprs-context.c: In function ‘gemalto_gprs_activate_primary’:
drivers/gemaltomodem/gprs-context.c:195:13: error: the comparison will always evaluate as ‘true’ for the address of ‘apn’ will never be NULL [-Werror=address]
195 | if (ctx->apn)
| ^~~
In file included from drivers/gemaltomodem/gprs-context.c:36:
./include/ofono/gprs-context.h:44:14: note: ‘apn’ declared here
44 | char apn[OFONO_GPRS_MAX_APN_LENGTH + 1];
| ^~~
| -rw-r--r-- | drivers/gemaltomodem/gprs-context.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gemaltomodem/gprs-context.c b/drivers/gemaltomodem/gprs-context.c index c0837bed..336748dc 100644 --- a/drivers/gemaltomodem/gprs-context.c +++ b/drivers/gemaltomodem/gprs-context.c @@ -192,8 +192,7 @@ static void gemalto_gprs_activate_primary(struct ofono_gprs_context *gc, break; } - if (ctx->apn) - snprintf(buf + len, sizeof(buf) - len - 3, ",\"%s\"", ctx->apn); + snprintf(buf + len, sizeof(buf) - len - 3, ",\"%s\"", ctx->apn); if (g_at_chat_send(gcd->chat, buf, none_prefix, cgdcont_enable_cb, gc, NULL)) |