diff options
| author | Sergei Golubtsov <s.e.golubtsov@gmail.com> | 2021-01-07 23:40:16 +0300 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2021-01-07 23:17:45 -0600 |
| commit | c8ed7162d5550c6d82fd604ecc47ca6cbfc91227 (patch) | |
| tree | 356032a3cc58d10ef0f14fe420d95ad31ad68e9d | |
| parent | 41967b92f333d6a17a51f1a44e91f7af7bc121fc (diff) | |
| download | ofono-c8ed7162d5550c6d82fd604ecc47ca6cbfc91227.tar.gz | |
ppp: using RX ACCM = 0 by default
Some modems such as Quectel EC200T do not honor the default value for
the Async-Control-Character-Map (ACCM) configuration option defined in
RFC 1548 6.2 as 0xffffffff. This patch suggests to use RX ACCM = 0 for
Ofono by default as pppd does for instance. This will reduce PPP data
overhead as well.
| -rw-r--r-- | gatchat/gatppp.c | 5 | ||||
| -rw-r--r-- | gatchat/gatppp.h | 1 | ||||
| -rw-r--r-- | gatchat/ppp.h | 1 | ||||
| -rw-r--r-- | gatchat/ppp_lcp.c | 15 |
4 files changed, 21 insertions, 1 deletions
diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 141e2746..259e6d5c 100644 --- a/gatchat/gatppp.c +++ b/gatchat/gatppp.c @@ -806,6 +806,11 @@ void g_at_ppp_set_server_info(GAtPPP *ppp, const char *remote, ipcp_set_server_info(ppp->ipcp, r, d1, d2); } +void g_at_ppp_set_accm(GAtPPP *ppp, guint32 accm) +{ + lcp_set_accm(ppp->lcp, accm); +} + void g_at_ppp_set_acfc_enabled(GAtPPP *ppp, gboolean enabled) { lcp_set_acfc_enabled(ppp->lcp, enabled); diff --git a/gatchat/gatppp.h b/gatchat/gatppp.h index dd203c28..a12e42e3 100644 --- a/gatchat/gatppp.h +++ b/gatchat/gatppp.h @@ -88,6 +88,7 @@ void g_at_ppp_set_recording(GAtPPP *ppp, const char *filename); void g_at_ppp_set_server_info(GAtPPP *ppp, const char *remote_ip, const char *dns1, const char *dns2); +void g_at_ppp_set_accm(GAtPPP *ppp, guint32 accm); void g_at_ppp_set_acfc_enabled(GAtPPP *ppp, gboolean enabled); void g_at_ppp_set_pfc_enabled(GAtPPP *ppp, gboolean enabled); diff --git a/gatchat/ppp.h b/gatchat/ppp.h index ac1a7ef2..6c02b053 100644 --- a/gatchat/ppp.h +++ b/gatchat/ppp.h @@ -90,6 +90,7 @@ static inline void __put_unaligned_short(void *p, guint16 val) struct pppcp_data *lcp_new(GAtPPP *ppp, gboolean dormant); void lcp_free(struct pppcp_data *lcp); void lcp_protocol_reject(struct pppcp_data *lcp, guint8 *packet, gsize len); +void lcp_set_accm(struct pppcp_data *pppcp, guint32 accm); void lcp_set_acfc_enabled(struct pppcp_data *pppcp, gboolean enabled); void lcp_set_pfc_enabled(struct pppcp_data *pppcp, gboolean enabled); diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c index 3fe38217..7c45a27f 100644 --- a/gatchat/ppp_lcp.c +++ b/gatchat/ppp_lcp.c @@ -121,7 +121,9 @@ static void lcp_generate_config_options(struct lcp_data *lcp) static void lcp_reset_config_options(struct lcp_data *lcp) { - /* Using the default ACCM */ + /* Using RX ACCM = 0 instead of the default ACCM */ + lcp->accm = 0; + lcp->req_options |= REQ_OPTION_ACCM; lcp_generate_config_options(lcp); } @@ -398,6 +400,17 @@ struct pppcp_data *lcp_new(GAtPPP *ppp, gboolean is_server) return pppcp; } +void lcp_set_accm(struct pppcp_data *pppcp, guint32 accm) +{ + struct lcp_data *lcp = pppcp_get_data(pppcp); + + lcp->accm = accm; + lcp->req_options |= REQ_OPTION_ACCM; + + lcp_generate_config_options(lcp); + pppcp_set_local_options(pppcp, lcp->options, lcp->options_len); +} + void lcp_set_acfc_enabled(struct pppcp_data *pppcp, gboolean enabled) { struct lcp_data *lcp = pppcp_get_data(pppcp); |