diff options
| author | Dana Keeler <dkeeler@mozilla.com> | 2021-04-27 20:39:04 +0200 |
|---|---|---|
| committer | Dana Keeler <dkeeler@mozilla.com> | 2021-04-27 20:39:04 +0200 |
| commit | e68cfce5f8a31130aa8146940a2b3f946c557db3 (patch) | |
| tree | 80ea91026dc813375d0260b182ba596eae8d2f73 | |
| parent | ded6b49e05963ddd15ba056c1548882aa95883a5 (diff) | |
| download | nspr-hg-e68cfce5f8a31130aa8146940a2b3f946c557db3.tar.gz | |
Bug 1686138 - Lock access to PRCallOnceType members in PR_CallOnce* for thread safety. r=kaieNSPR_4_31_BETA1
| -rw-r--r-- | pr/src/misc/prinit.c | 46 |
1 files changed, 32 insertions, 14 deletions
diff --git a/pr/src/misc/prinit.c b/pr/src/misc/prinit.c index 5ac99fe5..a952ad65 100644 --- a/pr/src/misc/prinit.c +++ b/pr/src/misc/prinit.c @@ -771,10 +771,15 @@ PR_IMPLEMENT(PRStatus) PR_CallOnce( _PR_ImplicitInitialization(); } - if (!once->initialized) { + PR_Lock(mod_init.ml); + PRIntn initialized = once->initialized; + PRStatus status = once->status; + PR_Unlock(mod_init.ml); + if (!initialized) { if (PR_ATOMIC_SET(&once->inProgress, 1) == 0) { - once->status = (*func)(); + status = (*func)(); PR_Lock(mod_init.ml); + once->status = status; once->initialized = 1; PR_NotifyAllCondVar(mod_init.cv); PR_Unlock(mod_init.ml); @@ -783,14 +788,18 @@ PR_IMPLEMENT(PRStatus) PR_CallOnce( while (!once->initialized) { PR_WaitCondVar(mod_init.cv, PR_INTERVAL_NO_TIMEOUT); } + status = once->status; PR_Unlock(mod_init.ml); + if (PR_SUCCESS != status) { + PR_SetError(PR_CALL_ONCE_ERROR, 0); + } } - } else { - if (PR_SUCCESS != once->status) { - PR_SetError(PR_CALL_ONCE_ERROR, 0); - } + return status; + } + if (PR_SUCCESS != status) { + PR_SetError(PR_CALL_ONCE_ERROR, 0); } - return once->status; + return status; } PR_IMPLEMENT(PRStatus) PR_CallOnceWithArg( @@ -802,10 +811,15 @@ PR_IMPLEMENT(PRStatus) PR_CallOnceWithArg( _PR_ImplicitInitialization(); } - if (!once->initialized) { + PR_Lock(mod_init.ml); + PRIntn initialized = once->initialized; + PRStatus status = once->status; + PR_Unlock(mod_init.ml); + if (!initialized) { if (PR_ATOMIC_SET(&once->inProgress, 1) == 0) { - once->status = (*func)(arg); + status = (*func)(arg); PR_Lock(mod_init.ml); + once->status = status; once->initialized = 1; PR_NotifyAllCondVar(mod_init.cv); PR_Unlock(mod_init.ml); @@ -814,14 +828,18 @@ PR_IMPLEMENT(PRStatus) PR_CallOnceWithArg( while (!once->initialized) { PR_WaitCondVar(mod_init.cv, PR_INTERVAL_NO_TIMEOUT); } + status = once->status; PR_Unlock(mod_init.ml); + if (PR_SUCCESS != status) { + PR_SetError(PR_CALL_ONCE_ERROR, 0); + } } - } else { - if (PR_SUCCESS != once->status) { - PR_SetError(PR_CALL_ONCE_ERROR, 0); - } + return status; + } + if (PR_SUCCESS != status) { + PR_SetError(PR_CALL_ONCE_ERROR, 0); } - return once->status; + return status; } PRBool _PR_Obsolete(const char *obsolete, const char *preferred) |