summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* test: move `test-cluster-primary-error` flaky testHEADmainYagiz Nizipli2023-05-172-4/+4
| | | | | PR-URL: https://github.com/nodejs/node/pull/48039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
* doc: update process.versions propertiesSaba Kharanauli2023-05-171-15/+24
| | | | | | | | | Fixes: https://github.com/nodejs/node/issues/48016 PR-URL: https://github.com/nodejs/node/pull/48019 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: fix suite signalBenjamin Gruenbaum2023-05-173-11/+58
| | | | | | PR-URL: https://github.com/nodejs/node/pull/47800 Fixes: https://github.com/nodejs/node/issues/47882 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: fix parsing test flagsDaeyeon Jeong2023-05-171-3/+1
| | | | | | | | This removes replacing `_` with `-` in the flags defined. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/48012 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* benchmark: use `cluster.isPrimary` instead of `cluster.isMaster`Deokjin Kim2023-05-172-2/+2
| | | | | | | | | | `cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: https://github.com/nodejs/node/pull/47981 PR-URL: https://github.com/nodejs/node/pull/48002 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: update remark-preset-lint-node to 4.0.0Node.js GitHub Bot2023-05-173-701/+775
| | | | | PR-URL: https://github.com/nodejs/node/pull/47995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* meta: move one or more collaborators to emeritusNode.js GitHub Bot2023-05-171-2/+2
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/48010 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: update ada to 2.4.1Node.js GitHub Bot2023-05-173-55/+159
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/48036 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64Shi Pujin2023-05-1651-1/+46832
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46401 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: update undici to 5.22.1Node.js GitHub Bot2023-05-1627-78/+1422
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/47994 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* doc: fix typo in binding functionsDeokjin Kim2023-05-161-1/+1
| | | | | | | | | | According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`). PR-URL: https://github.com/nodejs/node/pull/48003 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* 2023-05-16, Version 20.2.0 (Current)Michaël Zasso2023-05-164-5/+125
| | | | | | | | | | | | | | | | | Notable changes: doc: * add ovflowd to collaborators (Claudio Wunder) https://github.com/nodejs/node/pull/47844 http: * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) https://github.com/nodejs/node/pull/47732 sea: * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) https://github.com/nodejs/node/pull/47588 test_runner: * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) https://github.com/nodejs/node/pull/47909 url: * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) https://github.com/nodejs/node/pull/47885 PR-URL: https://github.com/nodejs/node/pull/48020
* doc: mark Node.js 14 as End-of-LifeRichard Lau2023-05-161-50/+1
| | | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/48023 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTEDTobias Nießen2023-05-161-2/+3
| | | | | | | | | | | | The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine. PR-URL: https://github.com/nodejs/node/pull/47976 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* crypto: remove default encoding from cipherTobias Nießen2023-05-161-6/+0
| | | | | | Refs: https://github.com/nodejs/node/pull/47182 PR-URL: https://github.com/nodejs/node/pull/47998 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add heading for permission model limitationsTobias Nießen2023-05-151-0/+2
| | | | | | | | | | These limitations are not specific to the file system, so they should not be listed in the "File System Permissions" section. PR-URL: https://github.com/nodejs/node/pull/47989 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* crypto: fix setEngine() when OPENSSL_NO_ENGINE setTobias Nießen2023-05-151-0/+3
| | | | | | | | | | | | | | | When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently throws an internal error because the C++ binding does not export the relevant function, which causes _setEngine() to be undefined within JS. Instead, match the behavior of tls/secure-context.js and throw the existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL has been configured with OPENSSL_NO_ENGINE. PR-URL: https://github.com/nodejs/node/pull/47977 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* test_runner: use v8.serialize instead of TAPMoshe Atlow2023-05-1519-4600/+303
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47867 Fixes: https://github.com/nodejs/node/issues/44656 Fixes: https://github.com/nodejs/node/issues/47955 Fixes: https://github.com/nodejs/node/issues/47481 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* permission: remove unused function declarationDeokjin Kim2023-05-151-3/+0
| | | | | | | | | | | | RestrictAccess() is declared, but it's not used. PR-URL: https://github.com/nodejs/node/pull/47957 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
* src: deduplicate X509Certificate::Fingerprint*Tobias Nießen2023-05-152-36/+18
| | | | | | | | | All three functions do the same, except using different cryptographic hash functions. Move the common logic into a new template and use it directly. PR-URL: https://github.com/nodejs/node/pull/47978 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* test: mark test-esm-loader-http-imports as flakyTobias Nießen2023-05-151-0/+4
| | | | | | | | | This test has been failing occasionally for weeks. Refs: https://github.com/nodejs/node/issues/47836 Refs: https://github.com/nodejs/reliability/issues/564 PR-URL: https://github.com/nodejs/node/pull/47987 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* vm: fix crash when setting __proto__ on context's globalThisFeng Yu2023-05-152-1/+15
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/47939 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* test_runner: add shorthands to `test`Chemi Atlow2023-05-154-10/+72
| | | | | PR-URL: https://github.com/nodejs/node/pull/47909 Fixes: https://github.com/nodejs/node/issues/47897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* src: stop copying code cache, part 2Keyhan Vakil2023-05-153-51/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes more copies of the code cache data. First: for the builtin snapshot, we were copying the code cache to create a `std::vector<uint8_t>`. This was slowing down static intialization. Change it to use a good old `uint8_t*` and `size_t` rather than a vector. For the case of embedder provided snapshots, we also add an `owning_ptr` so that we can properly cleanup owned values created from the snapshot. Second: whenever the code cache was hit, we would remove the bytecode from the code cache, and then reserialize it from the compiled function. This was pretty slow. Change the code so that we can reuse the same code cache multiple times. If the code cache is rejected (say, because the user added V8 options), then we need to generate the bytecode, in which case we again use `owning_ptr` to ensure that the underlying code cache is freed. Combined, these changes improve the misc/startup.js benchmarks significantly (p < 0.001): * process,benchmark/fixtures/require-builtins: 22.15% * process,test/fixtures/semicolon: 8.55% * worker,benchmark/fixtures/require-builtins: 26.52% * worker,test/fixtures/semicolon: 21.52% PR-URL: https://github.com/nodejs/node/pull/47958 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* deps: update simdutf to 3.2.9Node.js GitHub Bot2023-05-142-182/+207
| | | | | PR-URL: https://github.com/nodejs/node/pull/47983 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
* doc: add missing deprecated blocks to clusterTobias Nießen2023-05-141-0/+4
| | | | | | | | | I believe that these are required so that the respective APIs are marked as deprecated in the table of contents. PR-URL: https://github.com/nodejs/node/pull/47981 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
* meta: bump step-security/harden-runner from 2.3.1 to 2.4.0Rich Trott2023-05-141-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/47980 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
* meta: bump github/codeql-action from 2.3.2 to 2.3.3Rich Trott2023-05-141-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/47979 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: debug log for nghttp3Marco Ippolito2023-05-141-0/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47992 Refs: https://github.com/nodejs/node/pull/47576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* url: add value argument to has and delete methodsSankalp Shubham2023-05-1415-607/+707
| | | | | | | | | | | | | | | The change aims to add value argument to two methods of URLSearchParams class i.e the has method and the delete method. For has method, if value argument is provided, then use it to check for presence. For delete method, if value argument provided, use it to delete. Fixes: https://github.com/nodejs/node/issues/47883 PR-URL: https://github.com/nodejs/node/pull/47885 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* src: add cjs_module_lexer_version base64_versionJithil P Ponnan2023-05-147-2/+46
| | | | | | | | | src: add cjs_module_lexer_version base64_version PR-URL: https://github.com/nodejs/node/pull/45629 Refs: https://github.com/nodejs/node/issues/45260 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* esm: do not use `'beforeExit'` on the main threadAntoine du Hamel2023-05-142-17/+20
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/47964 Fixes: https://github.com/nodejs/node/issues/47929 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* doc: update description of globalTobias Nießen2023-05-131-4/+8
| | | | | | | | With widespread support for ES modules, the description of global is outdated now. PR-URL: https://github.com/nodejs/node/pull/47969 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* meta: bump actions/setup-python from 4.5.0 to 4.6.0Rich Trott2023-05-131-1/+1
| | | | | | | | | Sync with other files updated in dca352a9b6acb. PR-URL: https://github.com/nodejs/node/pull/47968 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: update measure memory rejection informationYash Ladha2023-05-131-1/+2
| | | | | | | | | | If in case context is unable to allocate a promise then `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise rejection) in the vm measureMemory call. PR-URL: https://github.com/nodejs/node/pull/41639 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
* http: prevent writing to the body when not allowed by HTTP specGerrard Lindsay2023-05-138-12/+142
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/47732 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* vm,lib: refactor microtaskQueue assignment logicXadillaX2023-05-131-8/+6
| | | | | | | | | | | Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: https://github.com/nodejs/node/pull/47765 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: fix broken link to TC39 import attributes proposalRich Trott2023-05-132-2/+2
| | | | | | | | | | | | The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to. PR-URL: https://github.com/nodejs/node/pull/47954 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* test: add getRandomValues return lengthJithil P Ponnan2023-05-131-0/+5
| | | | PR-URL: https://github.com/nodejs/node/pull/46357 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* doc: fix broken linkRich Trott2023-05-121-1/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47953 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* worker: support more cases when (de)serializing errorsMoshe Atlow2023-05-122-11/+111
| | | | | | | | | - error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect PR-URL: https://github.com/nodejs/node/pull/47925 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* lib: update commentsinkhaha2023-05-121-1/+1
| | | | | | | | | | Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP. PR-URL: https://github.com/nodejs/node/pull/47884 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: unskip negative-settimeout.any.js WPTFilip Skokan2023-05-121-5/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/47946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* crypto: remove default encoding from scryptTobias Nießen2023-05-121-8/+2
| | | | | | | | Refs: https://github.com/nodejs/node/pull/47182 PR-URL: https://github.com/nodejs/node/pull/47943 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: remove broken linkRich Trott2023-05-111-3/+2
| | | | | | | | Closes: https://github.com/nodejs/node/issues/47940 PR-URL: https://github.com/nodejs/node/pull/47942 Fixes: https://github.com/nodejs/node/issues/47940 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* meta: add security-wg ping to permission.jsRafael Gonzaga2023-05-111-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47941 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* net: fix family autoselection timeout handlingPaolo Insogna2023-05-112-16/+80
| | | | | PR-URL: https://github.com/nodejs/node/pull/47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* permission: resolve reference to absolute path only for fs permissionDaeyeon Jeong2023-05-111-2/+5
| | | | | | | | | For other candidate permissions, such as "net" or "env", this patch will pass the reference without resolving it to an absolute path. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/47930 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
* src: move BlobSerializerDeserializer to a separate header fileDarshan Sen2023-05-114-332/+490
| | | | | | | | | | | | | | | This should make it possible to reuse the BlobSerializer and the BlobDeserializer classes in SEAs to generate and parse the injected blob. This change also resolves this TODO: https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187 Refs: https://github.com/nodejs/node/pull/47458 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/47933 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test_runner: fix ordering of test hooksPhil Nash2023-05-112-5/+10
| | | | | | | | | | | | | For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations. Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up. Fixes #47915 PR-URL: https://github.com/nodejs/node/pull/47931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
View Lorry Controller Status