diff options
author | gengjiawen <technicalcute@gmail.com> | 2019-03-17 21:28:29 +0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-03-26 09:46:41 -0700 |
commit | 8209caec3955c029c47d32f0babef627500f3c65 (patch) | |
tree | ed8bab6dffd0cae3d6cdc9a3444ce6fb3a60b5dc /tools/eslint-rules | |
parent | 3018441304697fe801fc81385229b5a78a62cc54 (diff) | |
download | node-new-8209caec3955c029c47d32f0babef627500f3c65.tar.gz |
tools: remove eslint rule no-let-in-for-declaration
PR-URL: https://github.com/nodejs/node/pull/26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'tools/eslint-rules')
-rw-r--r-- | tools/eslint-rules/no-let-in-for-declaration.js | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/tools/eslint-rules/no-let-in-for-declaration.js b/tools/eslint-rules/no-let-in-for-declaration.js deleted file mode 100644 index 1ae49a48de..0000000000 --- a/tools/eslint-rules/no-let-in-for-declaration.js +++ /dev/null @@ -1,38 +0,0 @@ -/** - * @fileoverview Prohibit the use of `let` as the loop variable - * in the initialization of for, and the left-hand - * iterator in forIn and forOf loops. - * - * @author Jessica Quynh Tran - */ - -'use strict'; - -//------------------------------------------------------------------------------ -// Rule Definition -//------------------------------------------------------------------------------ -const message = 'Use of `let` as the loop variable in a for-loop is ' + - 'not recommended. Please use `var` instead.'; -const forSelector = 'ForStatement[init.kind="let"]'; -const forInOfSelector = 'ForOfStatement[left.kind="let"],' + - 'ForInStatement[left.kind="let"]'; - -module.exports = { - create(context) { - const sourceCode = context.getSourceCode(); - - function report(node) { - context.report({ - node, - message, - fix: (fixer) => - fixer.replaceText(sourceCode.getFirstToken(node), 'var') - }); - } - - return { - [forSelector]: (node) => report(node.init), - [forInOfSelector]: (node) => report(node.left), - }; - } -}; |