test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 7 insertions, 6 deletions

diff --git a/test/parallel/test-http-keep-alive.js b/test/parallel/test-http-keep-alive.js
index 0d30bbe1da..d48732e116 100644
--- a/test/parallel/test-http-keep-alive.js
+++ b/test/parallel/test-http-keep-alive.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 var http = require('http');
 
@@ -13,11 +13,12 @@ var server = http.createServer(function(req, res) {
 
 var agent = new http.Agent({maxSockets: 1});
 var headers = {'connection': 'keep-alive'};
-var name = agent.getName({ port: common.PORT });
+var name;
 
-server.listen(common.PORT, function() {
+server.listen(0, function() {
+  name = agent.getName({ port: this.address().port });
   http.get({
-    path: '/', headers: headers, port: common.PORT, agent: agent
+    path: '/', headers: headers, port: this.address().port, agent: agent
   }, function(response) {
     assert.equal(agent.sockets[name].length, 1);
     assert.equal(agent.requests[name].length, 2);
@@ -25,7 +26,7 @@ server.listen(common.PORT, function() {
   });
 
   http.get({
-    path: '/', headers: headers, port: common.PORT, agent: agent
+    path: '/', headers: headers, port: this.address().port, agent: agent
   }, function(response) {
     assert.equal(agent.sockets[name].length, 1);
     assert.equal(agent.requests[name].length, 1);
@@ -33,7 +34,7 @@ server.listen(common.PORT, function() {
   });
 
   http.get({
-    path: '/', headers: headers, port: common.PORT, agent: agent
+    path: '/', headers: headers, port: this.address().port, agent: agent
   }, function(response) {
     response.on('end', function() {
       assert.equal(agent.sockets[name].length, 1);