diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2022-10-14 15:53:19 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-14 13:53:19 +0000 |
| commit | d1bb8d39cbdcee562c5e754a6515908c17c943e7 (patch) | |
| tree | 1de3a991045d5dfe37a3b16fe5aea7a7ff3243ab /src/node_snapshotable.cc | |
| parent | 91dbd8bb1ce75adaad8b281cdc0179a06abc7e40 (diff) | |
| download | node-new-d1bb8d39cbdcee562c5e754a6515908c17c943e7.tar.gz | |
src: return void in InitializeInspector()
We have been ignoring inspector port binding errors during startup.
Handling this error would be a breaking change and it's probably
surprising to refuse to launch the Node.js instance simply because
the inspector cannot listen to the port anyway. So just turn the
return value of InitializeInspector() and remove the TODOs for
handling the error.
PR-URL: https://github.com/nodejs/node/pull/44903
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_snapshotable.cc')
| -rw-r--r-- | src/node_snapshotable.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc index 6a6b899cb8..a5fda9aa5a 100644 --- a/src/node_snapshotable.cc +++ b/src/node_snapshotable.cc @@ -1173,8 +1173,6 @@ ExitCode SnapshotBuilder::Generate(SnapshotData* out, // in the future). if (snapshot_type == SnapshotMetadata::Type::kFullyCustomized) { #if HAVE_INSPECTOR - // TODO(joyeecheung): handle the exit code returned by - // InitializeInspector(). env->InitializeInspector({}); #endif if (LoadEnvironment(env, StartExecutionCallback{}).IsEmpty()) { |