diff options
| author | Anna Henningsen <anna.henningsen@mongodb.com> | 2023-02-20 23:01:45 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-20 22:01:45 +0000 |
| commit | b85b5ba10cd782a31e5b1bb26e496b19309e2084 (patch) | |
| tree | 7740c2e6d2ddd324a889960584e4e356156a0404 /src/node_errors.cc | |
| parent | ff92b40ffcb5f61579f08f95a3586953983bf206 (diff) | |
| download | node-new-b85b5ba10cd782a31e5b1bb26e496b19309e2084.tar.gz | |
src: use string_view for report and related code
Use `std::string_view` for process.report code and related
code, drop a few unnecessary `std::to_string` calls,
and use `MaybeStackBuffer` instead of `MallocedBuffer`,
all in order to avoid unnecessary heap allocations.
PR-URL: https://github.com/nodejs/node/pull/46723
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Diffstat (limited to 'src/node_errors.cc')
| -rw-r--r-- | src/node_errors.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/node_errors.cc b/src/node_errors.cc index 05f2a84849..7f2128dacb 100644 --- a/src/node_errors.cc +++ b/src/node_errors.cc @@ -420,8 +420,10 @@ static void ReportFatalException(Environment* env, // Not an error object. Just print as-is. node::Utf8Value message(env->isolate(), error); - FPrintF(stderr, "%s\n", - *message ? message.ToString() : "<toString() threw exception>"); + FPrintF( + stderr, + "%s\n", + *message ? message.ToStringView() : "<toString() threw exception>"); } else { node::Utf8Value name_string(env->isolate(), name.ToLocalChecked()); node::Utf8Value message_string(env->isolate(), message.ToLocalChecked()); |