diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-03-01 21:31:40 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-03-05 00:56:37 +0100 |
| commit | 955be8623d58566849cf6a59ff82e78cf14f239a (patch) | |
| tree | ff4ad2ccd691527045ef10eb57f5b5dc4c773dac /src/node_env_var.cc | |
| parent | 1bdcfa7abe308bb7f79cd3679e9f345b58b37334 (diff) | |
| download | node-new-955be8623d58566849cf6a59ff82e78cf14f239a.tar.gz | |
src: use object to pass `Environment` to functions
Use a `v8::Object` with an internal field, rather than a
`v8::External`.
On a `GetReturnValue().Set(Environment::GetCurrent(args) == nullptr)`
noop function, this benchmarks as a ~60 % speedup, as calls to
`obj->GetAlignedPointerFromInternalField()` can be inlined and
the field is stored with one level of indirection less.
This also makes breaking up some pieces of the `Environment` class
into per-native-binding data easier, if we want to pursue that path
in the future.
PR-URL: https://github.com/nodejs/node/pull/26382
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/node_env_var.cc')
| -rw-r--r-- | src/node_env_var.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_env_var.cc b/src/node_env_var.cc index d994a2199a..7e4913702b 100644 --- a/src/node_env_var.cc +++ b/src/node_env_var.cc @@ -212,7 +212,7 @@ static void EnvEnumerator(const PropertyCallbackInfo<Array>& info) { MaybeLocal<Object> CreateEnvVarProxy(Local<Context> context, Isolate* isolate, - Local<Value> data) { + Local<Object> data) { EscapableHandleScope scope(isolate); Local<ObjectTemplate> env_proxy_template = ObjectTemplate::New(isolate); env_proxy_template->SetHandler(NamedPropertyHandlerConfiguration( |