diff options
author | Jon Moss <me@jonathanmoss.me> | 2018-07-09 11:02:11 -0400 |
---|---|---|
committer | Jon Moss <me@jonathanmoss.me> | 2018-07-11 09:17:44 -0400 |
commit | fcfd3e1bac0c3c62360829aeac4c63a62a2f02f5 (patch) | |
tree | a2664c67e7f8bcde12796082d597265f4db65ce2 /src/env.h | |
parent | 8174d0c8cae857296c45b2c448348f2c781f6ace (diff) | |
download | node-new-fcfd3e1bac0c3c62360829aeac4c63a62a2f02f5.tar.gz |
src: make Environment::is_stopping_worker inline
Fixes a TODO comment.
PR-URL: https://github.com/nodejs/node/pull/21720
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/env.h')
-rw-r--r-- | src/env.h | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -723,9 +723,6 @@ class Environment { inline bool can_call_into_js() const; inline void set_can_call_into_js(bool can_call_into_js); - // TODO(addaleax): This should be inline. - bool is_stopping_worker() const; - inline bool is_main_thread() const; inline uint64_t thread_id() const; inline void set_thread_id(uint64_t id); @@ -734,6 +731,7 @@ class Environment { inline void add_sub_worker_context(worker::Worker* context); inline void remove_sub_worker_context(worker::Worker* context); void stop_sub_worker_contexts(); + inline bool is_stopping_worker() const; inline void ThrowError(const char* errmsg); inline void ThrowTypeError(const char* errmsg); |