diff options
author | Tobias Nießen <tniessen@tnie.de> | 2021-08-12 22:24:24 +0200 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2021-08-15 11:10:12 -0700 |
commit | fdce138e1dd86f63f141cbd5ec6b670eeec68986 (patch) | |
tree | 8f786981e1adfccbfeaa33fdf82e99efd4074bc2 /lib | |
parent | b24ab473d51d7bd9b781b0ef52c940089087a799 (diff) | |
download | node-new-fdce138e1dd86f63f141cbd5ec6b670eeec68986.tar.gz |
policy: fix integrity when DEFAULT_ENCODING is settest
PR-URL: https://github.com/nodejs/node/pull/39750
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/internal/policy/manifest.js | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/internal/policy/manifest.js b/lib/internal/policy/manifest.js index c3ec82f596..a8420343db 100644 --- a/lib/internal/policy/manifest.js +++ b/lib/internal/policy/manifest.js @@ -501,8 +501,10 @@ class Manifest { value: expected } = integrityEntries[i]; const hash = createHash(algorithm); - HashUpdate(hash, content); - const digest = HashDigest(hash); + // TODO(tniessen): the content should not be passed as a string in the + // first place, see https://github.com/nodejs/node/issues/39707 + HashUpdate(hash, content, 'utf8'); + const digest = HashDigest(hash, 'buffer'); if (digest.length === expected.length && timingSafeEqual(digest, expected)) { return true; |