readline,repl: improve history up/previous

Reaching the history end caused the last entry to be persistent.
That way there's no actualy feedback to the user that the history
end is reached. Instead, visualize the original input line and keep
the history index at the history end in case the user wants to go
back again.

PR-URL: https://github.com/nodejs/node/pull/31112
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/lib/readline.js b/lib/readline.js
index b7b2651aec..5f3aeedd4e 100644
--- a/lib/readline.js
+++ b/lib/readline.js
@@ -718,7 +718,7 @@ Interface.prototype._historyNext = function() {
 };
 
 Interface.prototype._historyPrev = function() {
-  if (this.historyIndex < this.history.length) {
+  if (this.historyIndex < this.history.length && this.history.length) {
     const search = this[kSubstringSearch] || '';
     let index = this.historyIndex + 1;
     while (index < this.history.length &&
@@ -727,9 +727,7 @@ Interface.prototype._historyPrev = function() {
       index++;
     }
     if (index === this.history.length) {
-      // TODO(BridgeAR): Change this to:
-      // this.line = search;
-      return;
+      this.line = search;
     } else {
       this.line = this.history[index];
     }