diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-23 22:21:52 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-24 00:56:23 +0800 |
commit | a41a4ee61b25698394aeda277546605ea25070c1 (patch) | |
tree | 0bfaec98a4e781a228c4bec457df3fbc34658d5c /configure.py | |
parent | d896f03578f2312aaae347de3b5a0b26882effc8 (diff) | |
download | node-new-a41a4ee61b25698394aeda277546605ea25070c1.tar.gz |
build: disable custom v8 snapshot by default
This currently breaks `test/pummel/test-hash-seed.js`
PR-URL: https://github.com/nodejs/node/pull/27365
Refs: https://github.com/nodejs/node/pull/27321
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'configure.py')
-rwxr-xr-x | configure.py | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/configure.py b/configure.py index 1a0819e741..12d68ccfeb 100755 --- a/configure.py +++ b/configure.py @@ -421,6 +421,11 @@ parser.add_option('--with-ltcg', dest='with_ltcg', help='Use Link Time Code Generation. This feature is only available on Windows.') +parser.add_option('--with-node-snapshot', + action='store_true', + dest='with_node_snapshot', + help='Turn on V8 snapshot integration. Currently experimental.') + intl_optgroup.add_option('--download', action='store', dest='download_list', @@ -928,6 +933,13 @@ def configure_node(o): o['variables']['want_separate_host_toolset'] = int( cross_compiling and want_snapshots) + if options.with_node_snapshot: + o['variables']['node_use_node_snapshot'] = 'true' + else: + # Default to false for now. + # TODO(joyeecheung): enable it once we fix the hashseed uniqueness + o['variables']['node_use_node_snapshot'] = 'false' + if target_arch == 'arm': configure_arm(o) |