diff options
| author | legendecas <legendecas@gmail.com> | 2021-07-20 11:56:36 +0800 |
|---|---|---|
| committer | legendecas <legendecas@gmail.com> | 2021-07-23 13:47:00 +0800 |
| commit | 834ae63d61ea4302a68a22cf8bd08e80c6d38ea4 (patch) | |
| tree | 5cfae65c70c93c935b2ad595a9d95824f96545ce | |
| parent | 3fb484f4e3e5944be445203a38520ef91e96de4e (diff) | |
| download | node-new-834ae63d61ea4302a68a22cf8bd08e80c6d38ea4.tar.gz | |
src: print native module id on native module not found
To help core contributors identify which file is missing from the build.
PR-URL: https://github.com/nodejs/node/pull/39460
Refs: https://github.com/nodejs/node/issues/39408
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | src/node_native_module.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/node_native_module.cc b/src/node_native_module.cc index a5aa1edaf9..c4fd96c75c 100644 --- a/src/node_native_module.cc +++ b/src/node_native_module.cc @@ -224,7 +224,10 @@ MaybeLocal<String> NativeModuleLoader::LoadBuiltinModuleSource(Isolate* isolate, isolate, contents.c_str(), v8::NewStringType::kNormal, contents.length()); #else const auto source_it = source_.find(id); - CHECK_NE(source_it, source_.end()); + if (UNLIKELY(source_it == source_.end())) { + fprintf(stderr, "Cannot find native builtin: \"%s\".\n", id); + ABORT(); + } return source_it->second.ToStringChecked(isolate); #endif // NODE_BUILTIN_MODULES_PATH } |