diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-06-08 09:48:48 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-06-12 20:13:04 -0700 |
| commit | 60cbbd074c382853504f04317e7397692f0f4713 (patch) | |
| tree | 500f1d466da6ab0361ee7d444e4e74462a1c65c8 | |
| parent | 4bf39971076702f195cb2c65c3432f5d23ad76e7 (diff) | |
| download | node-new-v9.x-staging.tar.gz | |
tools: update tooling to work with new macOS CLI …v9.x-staging
Using High Sierra and `xcode-select --install` without installing full
Xcode, our build tooling breaks due to faulty regular expressions.
Update the `configure` script in our project root directory to handle
multi-digit version numbers.
`tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be
updated for a complete fix.
PR-URL: https://github.com/nodejs/node/pull/21173
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rwxr-xr-x | configure | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -650,7 +650,7 @@ def get_llvm_version(cc): def get_xcode_version(cc): return get_version_helper( - cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)") + cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)") def get_gas_version(cc): try: |