ChangeLog entriesdelete-ecc-g

2 files changed, 23 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index fd004c66..1af94c09 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,25 @@
+2020-01-26  Niels Möller  <nisse@lysator.liu.se>
+
+	* ecc-internal.h (struct ecc_curve): Delete g, the curve
+	generator, since it was used only by tests. Update all curve
+	instances.
+
+	* eccdata.c (output_curve): Delete output of ecc_g.
+	(output_point): Delete name argument, and update callers.
+
+	* testsuite/testutils.c (ecc_ref): Table of reference points moved
+	out of test_ecc_mul_a. Add generator to the list of points.
+	(test_ecc_mul_a): Use ecc_ref table also for the n == 1 case.
+	(test_ecc_ga, test_ecc_get_g, test_ecc_get_ga): New functions,
+	using the tabulated generator.
+
+	* testsuite/ecc-add-test.c: Use test_ecc_get_g, instead of
+	accessing ecc->g.
+	* testsuite/ecc-dup-test.c: Likewise.
+	* testsuite/ecc-mul-a-test.c: Use test_ecc_get_ga and test_ecc_ga.
+	Delete special case for n == 1.
+	* testsuite/ecc-mul-g-test.c: Use test_ecc_ga.
+
 2020-01-25  Niels Möller  <nisse@lysator.liu.se>
 
 	* examples/hogweed-benchmark.c (bench_curve_init): Pass correct
diff --git a/testsuite/testutils.h b/testsuite/testutils.h
index 2d4f8ff9..899f9851 100644
--- a/testsuite/testutils.h
+++ b/testsuite/testutils.h
@@ -295,7 +295,7 @@ test_ecc_mul_h (unsigned curve, unsigned n, const mp_limb_t *p);
 void
 test_ecc_ga (unsigned curve, const mp_limb_t *p);
 
-/* Gets the curve generator, with coordinated in redc form, if
+/* Gets the curve generator, with coordinates in redc form, if
    appropriate, and with an appended z = 1 coordinate. */
 void
 test_ecc_get_g (unsigned curve, mp_limb_t *rp);