perl: change to the new, safer 3-operand form of open()

The 2-operand form was inherently unsafe.  Use the 3-operand form
instead, which guarantees that arbitrary filenames are supported.

This also means we can remove a few instances of sysopen() which was
used for exactly this reason, however, at least in theory sysopen()
isn't portable.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/macros/macros.pl b/macros/macros.pl
index d96324a2..d4bfa9fa 100755
--- a/macros/macros.pl
+++ b/macros/macros.pl
@@ -90,7 +90,7 @@ sub charcify(@) {
 #
 # Generate macros.c
 #
-open(OUT,"> macros/macros.c\0") or die "unable to open macros.c\n";
+open(OUT, '>', 'macros/macros.c') or die "unable to open macros.c\n";
 
 print OUT "/*\n";
 print OUT " * Do not edit - this file auto-generated by macros.pl from:\n";
@@ -116,7 +116,7 @@ my $z;
 foreach $args ( @ARGV ) {
     my @file_list = glob ( $args );
     foreach $fname ( @file_list ) {
-        open(INPUT,"< $fname\0") or die "$0: $fname: $!\n";
+        open(INPUT,'<', $fname) or die "$0: $fname: $!\n";
 	while (<INPUT>) {
 	    $line++;
 	    chomp;