diff options
| author | Florian Müllner <fmuellner@gnome.org> | 2023-04-03 20:17:29 +0200 |
|---|---|---|
| committer | Marge Bot <marge-bot@gnome.org> | 2023-04-04 19:30:05 +0000 |
| commit | aa1eaa8120526413e3edc6b1399dfacc1542d40b (patch) | |
| tree | 003e128e445c6927e8b194951f780bdfa3dd1841 | |
| parent | 1e459c830232a14d6276af699ab864546941d5a9 (diff) | |
| download | mutter-aa1eaa8120526413e3edc6b1399dfacc1542d40b.tar.gz | |
output-xrandr: Consistently return -1 on error
Returning FALSE does not indicate an error, but a valid backlight
value of 0. Consumers expect a negative value to indicate no
backlight support, so return -1 in case of error, just like we
already do for invalid values.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2947>
| -rw-r--r-- | src/backends/x11/meta-output-xrandr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backends/x11/meta-output-xrandr.c b/src/backends/x11/meta-output-xrandr.c index bb6588de3..383babffb 100644 --- a/src/backends/x11/meta-output-xrandr.c +++ b/src/backends/x11/meta-output-xrandr.c @@ -526,7 +526,7 @@ output_get_backlight_xrandr (MetaOutput *output) &nitems, &bytes_after, &buffer); if (actual_type != XA_INTEGER || actual_format != 32 || nitems < 1) - return FALSE; + return -1; value = ((int*)buffer)[0]; if (value > 0) |