From aa1eaa8120526413e3edc6b1399dfacc1542d40b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 3 Apr 2023 20:17:29 +0200 Subject: output-xrandr: Consistently return -1 on error Returning FALSE does not indicate an error, but a valid backlight value of 0. Consumers expect a negative value to indicate no backlight support, so return -1 in case of error, just like we already do for invalid values. Part-of: --- src/backends/x11/meta-output-xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backends/x11/meta-output-xrandr.c b/src/backends/x11/meta-output-xrandr.c index bb6588de3..383babffb 100644 --- a/src/backends/x11/meta-output-xrandr.c +++ b/src/backends/x11/meta-output-xrandr.c @@ -526,7 +526,7 @@ output_get_backlight_xrandr (MetaOutput *output) &nitems, &bytes_after, &buffer); if (actual_type != XA_INTEGER || actual_format != 32 || nitems < 1) - return FALSE; + return -1; value = ((int*)buffer)[0]; if (value > 0) -- cgit v1.2.1