diff options
| author | Jonas Ådahl <jadahl@gmail.com> | 2020-11-04 20:48:54 +0100 |
|---|---|---|
| committer | Jonas Ådahl <jadahl@gmail.com> | 2020-11-16 14:13:07 +0100 |
| commit | 815ed52ca1413b33e6e694502ca45d3aae7c6d7c (patch) | |
| tree | a055e9d009535798ed2bfff9233fbc1153bdff25 /.gitlab-ci | |
| parent | 0c9f7c77350acad907882b3dd4e2ea5a7d1f3293 (diff) | |
| download | mutter-815ed52ca1413b33e6e694502ca45d3aae7c6d7c.tar.gz | |
ci: Wait for review stage before continuing
If review fails, it'll fail very early in the pipeline, but we won't see
the test case failure until the whole pipeline succeeds, which might be
10 minutes later.
To avoid sitting there wondering why it failed, let the time consuming
jobs wait until the review stage, which tends to take less than 20
seconds, succeeds. This way the review test result will be presented
earlier.
This changes the pipeline to run the check-commit-log job also for
non-merge requests, with the difference being that it will pass
immediately if it's not a merge request.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1549>
Diffstat (limited to '.gitlab-ci')
| -rwxr-xr-x | .gitlab-ci/check-commit-log.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.gitlab-ci/check-commit-log.sh b/.gitlab-ci/check-commit-log.sh index c309ff225..b6ca39767 100755 --- a/.gitlab-ci/check-commit-log.sh +++ b/.gitlab-ci/check-commit-log.sh @@ -1,8 +1,8 @@ #!/usr/bin/env bash if [ -z "$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" ]; then - echo Cannot review non-merge request - exit 1 + echo This is not a merge request, skipping + exit 0 fi git fetch $CI_MERGE_REQUEST_PROJECT_URL.git $CI_MERGE_REQUEST_TARGET_BRANCH_NAME |