diff options
author | Jussi Pakkanen <jpakkane@gmail.com> | 2021-03-10 21:41:15 +0200 |
---|---|---|
committer | Jussi Pakkanen <jpakkane@gmail.com> | 2021-03-23 00:12:59 +0200 |
commit | a165e17a7ebc50f207281fb85c1d66bb315a0996 (patch) | |
tree | 978cd9cbf9efed7162acc2831beb6803124314dc | |
parent | 4fda4f50120fb8464fdce279f970c70bd9526d96 (diff) | |
download | meson-nopipe.tar.gz |
Remove -pipe from default list of args. Closes #8508.nopipe
-rw-r--r-- | docs/markdown/snippets/nopipe.md | 10 | ||||
-rw-r--r-- | mesonbuild/compilers/fortran.py | 6 | ||||
-rw-r--r-- | mesonbuild/compilers/mixins/clike.py | 2 | ||||
-rw-r--r-- | mesonbuild/interpreter.py | 3 |
4 files changed, 11 insertions, 10 deletions
diff --git a/docs/markdown/snippets/nopipe.md b/docs/markdown/snippets/nopipe.md new file mode 100644 index 000000000..431205bcf --- /dev/null +++ b/docs/markdown/snippets/nopipe.md @@ -0,0 +1,10 @@ +## `-pipe` no longer used by default + +Meson used to add the `-pipe` command line argument to all compilers +that supported it, but no longer does. If you need this, then you can +add it manually. However note that you should not do this unless you +have actually measured that it provides performance improvements. In +our tests we could not find a case where adding `-pipe` made +compilation faster and using `-pipe` [can cause sporadic build +failures in certain +cases](https://github.com/mesonbuild/meson/issues/8508). diff --git a/mesonbuild/compilers/fortran.py b/mesonbuild/compilers/fortran.py index d65d5853c..a2820071b 100644 --- a/mesonbuild/compilers/fortran.py +++ b/mesonbuild/compilers/fortran.py @@ -335,12 +335,6 @@ class IntelFortranCompiler(IntelGnuLikeCompiler, FortranCompiler): def get_preprocess_only_args(self) -> T.List[str]: return ['-cpp', '-EP'] - def get_always_args(self) -> T.List[str]: - """Ifort doesn't have -pipe.""" - val = super().get_always_args() - val.remove('-pipe') - return val - def language_stdlib_only_link_flags(self) -> T.List[str]: return ['-lifcore', '-limf'] diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py index 787c2c124..87db2a424 100644 --- a/mesonbuild/compilers/mixins/clike.py +++ b/mesonbuild/compilers/mixins/clike.py @@ -154,7 +154,7 @@ class CLikeCompiler(Compiler): ''' Args that are always-on for all C compilers other than MSVC ''' - return ['-pipe'] + self.get_largefile_args() + return self.get_largefile_args() def get_no_stdinc_args(self) -> T.List[str]: return ['-nostdinc'] diff --git a/mesonbuild/interpreter.py b/mesonbuild/interpreter.py index 68744ef6b..26d844dda 100644 --- a/mesonbuild/interpreter.py +++ b/mesonbuild/interpreter.py @@ -4667,9 +4667,6 @@ different subdirectory. elif arg == '-g': mlog.warning(f'Consider using the built-in debug option instead of using "{arg}".', location=self.current_node) - elif arg == '-pipe': - mlog.warning("You don't need to add -pipe, Meson will use it automatically when it is available.", - location=self.current_node) elif arg.startswith('-fsanitize'): mlog.warning(f'Consider using the built-in option for sanitizers instead of using "{arg}".', location=self.current_node) |