summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek Olšák <marek.olsak@amd.com>2020-11-10 21:30:52 -0500
committerDylan Baker <dylan.c.baker@intel.com>2020-12-14 10:44:48 -0800
commitb3e977dd6b6e9ec9b341eae6acbf4883dbc7eea3 (patch)
treedd4011a9e6bc7ed254b1c8aa3fe72259567cb3ce
parent493400cf1e2bf5bf81d927ea637d1c5f55c6aae7 (diff)
downloadmesa-b3e977dd6b6e9ec9b341eae6acbf4883dbc7eea3.tar.gz
ac: fix min/max_good_num_cu_per_sa on gfx10.3 with disabled SEs
Fixes: 9538b9a68ed - radeonsi: add support for Sienna Cichlid Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7542>
-rw-r--r--src/amd/common/ac_gpu_info.c15
-rw-r--r--src/amd/common/ac_gpu_info.h3
-rw-r--r--src/amd/vulkan/winsys/null/radv_null_winsys.c1
3 files changed, 15 insertions, 4 deletions
diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c
index 3bfa1259ef1..1a6f0e41c13 100644
--- a/src/amd/common/ac_gpu_info.c
+++ b/src/amd/common/ac_gpu_info.c
@@ -521,6 +521,14 @@ bool ac_query_gpu_info(int fd, void *dev_p,
if (info->family == CHIP_KAVERI)
info->num_render_backends = 2;
+ /* Guess the number of enabled SEs because the kernel doesn't tell us. */
+ if (info->chip_class >= GFX10_3 && info->max_se > 1) {
+ unsigned num_rbs_per_se = info->num_render_backends / info->max_se;
+ info->num_se = util_bitcount(amdinfo->enabled_rb_pipes_mask) / num_rbs_per_se;
+ } else {
+ info->num_se = info->max_se;
+ }
+
info->clock_crystal_freq = amdinfo->gpu_counter_freq;
if (!info->clock_crystal_freq) {
fprintf(stderr, "amdgpu: clock crystal frequency is 0, timestamps will be wrong\n");
@@ -666,9 +674,9 @@ bool ac_query_gpu_info(int fd, void *dev_p,
*/
unsigned cu_group = info->chip_class >= GFX10 ? 2 : 1;
info->max_good_cu_per_sa = DIV_ROUND_UP(info->num_good_compute_units,
- (info->max_se * info->max_sh_per_se * cu_group)) * cu_group;
+ (info->num_se * info->max_sh_per_se * cu_group)) * cu_group;
info->min_good_cu_per_sa = (info->num_good_compute_units /
- (info->max_se * info->max_sh_per_se * cu_group)) * cu_group;
+ (info->num_se * info->max_sh_per_se * cu_group)) * cu_group;
memcpy(info->si_tile_mode_array, amdinfo->gb_tile_mode,
sizeof(amdinfo->gb_tile_mode));
@@ -962,6 +970,7 @@ void ac_print_gpu_info(struct radeon_info *info)
printf(" max_good_cu_per_sa = %i\n", info->max_good_cu_per_sa);
printf(" min_good_cu_per_sa = %i\n", info->min_good_cu_per_sa);
printf(" max_se = %i\n", info->max_se);
+ printf(" num_se = %i\n", info->num_se);
printf(" max_sh_per_se = %i\n", info->max_sh_per_se);
printf(" max_wave64_per_simd = %i\n", info->max_wave64_per_simd);
printf(" num_physical_sgprs_per_simd = %i\n", info->num_physical_sgprs_per_simd);
@@ -1289,7 +1298,7 @@ unsigned ac_get_compute_resource_limits(struct radeon_info *info,
if (info->chip_class >= GFX7) {
unsigned num_cu_per_se = info->num_good_compute_units /
- info->max_se;
+ info->num_se;
/* Force even distribution on all SIMDs in CU if the workgroup
* size is 64. This has shown some good improvements if # of CUs
diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h
index 70e53f16cb4..a76f480fdba 100644
--- a/src/amd/common/ac_gpu_info.h
+++ b/src/amd/common/ac_gpu_info.h
@@ -163,7 +163,8 @@ struct radeon_info {
uint32_t num_good_compute_units;
uint32_t max_good_cu_per_sa;
uint32_t min_good_cu_per_sa; /* min != max if SAs have different # of CUs */
- uint32_t max_se; /* shader engines */
+ uint32_t max_se; /* number of shader engines incl. disabled ones */
+ uint32_t num_se; /* number of enabled shader engines */
uint32_t max_sh_per_se; /* shader arrays per shader engine */
uint32_t max_wave64_per_simd;
uint32_t num_physical_sgprs_per_simd;
diff --git a/src/amd/vulkan/winsys/null/radv_null_winsys.c b/src/amd/vulkan/winsys/null/radv_null_winsys.c
index f8b7bf6ad78..7cacf82068d 100644
--- a/src/amd/vulkan/winsys/null/radv_null_winsys.c
+++ b/src/amd/vulkan/winsys/null/radv_null_winsys.c
@@ -103,6 +103,7 @@ static void radv_null_winsys_query_info(struct radeon_winsys *rws,
info->pci_id = gpu_info[info->family].pci_id;
info->has_syncobj_wait_for_submit = true;
info->max_se = 4;
+ info->num_se = 4;
if (info->chip_class >= GFX10_3)
info->max_wave64_per_simd = 16;
else if (info->chip_class >= GFX10)