diff options
| author | Marek Olšák <marek.olsak@amd.com> | 2020-02-27 16:06:47 -0500 |
|---|---|---|
| committer | Eric Engestrom <eric@engestrom.ch> | 2020-03-06 22:59:40 +0100 |
| commit | dba2d46d8c059d29d65b0fc43b0ce777620e5929 (patch) | |
| tree | feb35301c6d6da5889038c48836df0149dd6fcbe | |
| parent | d9ee96ba69c0265d80c35c891ab82c9f80b6cf83 (diff) | |
| download | mesa-dba2d46d8c059d29d65b0fc43b0ce777620e5929.tar.gz | |
Revert "mesa: check for z=0 in _mesa_Vertex3dv()"
This reverts commit f04d7439a0ad6e13ff2912ff824553b6bcf511a4.
It no longer helps performance and the current vbo implementation is
faster anyway.
The app that hit this was a CAD program called Spazio3D. It made pretty
terrible use of the OpenGL API and we sent them some tips for improvements.
I'm assuming they've fixed this by now.
Reviewed-by: Mathias Fröhlich <Mathias.Froehlich@web.de>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4052>
(cherry picked from commit df3891e74a72d275aceba91adc94a9e7dc9aa029)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/mesa/main/api_loopback.c | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/.pick_status.json b/.pick_status.json index 1a945a92853..0a80b02cbf6 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1147,7 +1147,7 @@ "description": "Revert \"mesa: check for z=0 in _mesa_Vertex3dv()\"", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "f04d7439a0ad6e13ff2912ff824553b6bcf511a4" }, diff --git a/src/mesa/main/api_loopback.c b/src/mesa/main/api_loopback.c index c03c33ee339..53873eae29e 100644 --- a/src/mesa/main/api_loopback.c +++ b/src/mesa/main/api_loopback.c @@ -631,10 +631,7 @@ _mesa_Vertex2sv( const GLshort *v ) void GLAPIENTRY _mesa_Vertex3dv( const GLdouble *v ) { - if (v[2] == 0.0) - VERTEX2( (GLfloat) v[0], (GLfloat) v[1] ); - else - VERTEX3( (GLfloat) v[0], (GLfloat) v[1], (GLfloat) v[2] ); + VERTEX3( (GLfloat) v[0], (GLfloat) v[1], (GLfloat) v[2] ); } void GLAPIENTRY |