diff options
| author | Lionel Landwerlin <lionel.g.landwerlin@intel.com> | 2019-12-03 16:19:24 +0200 |
|---|---|---|
| committer | Lionel Landwerlin <lionel.g.landwerlin@intel.com> | 2019-12-04 09:21:15 +0000 |
| commit | b364e920bf8c6805bcc3ff1cedf6b77dbb61b1e0 (patch) | |
| tree | e6e4e1ec72c84c9d3d08839b74313db32bd31772 | |
| parent | 9d0a5c817ce21adabeda5153035b30609e2862b2 (diff) | |
| download | mesa-b364e920bf8c6805bcc3ff1cedf6b77dbb61b1e0.tar.gz | |
intel/perf: take into account that reports read can be fairly old
If we read the OA reports late enough after the query happens, we can
get a timestamp in the report that is significantly in the past
compared to the start timestamp of the query. The current code must
deal with the wraparound of the timestamp value (every ~6 minute). So
consider that if the difference is greater than half that wraparound
period, we're probably dealing with an old report and make the caller
aware it should read more reports when they're available.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: <mesa-stable@lists.freedesktop.org>
Reviewed-by: Mark Janes <mark.a.janes@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
| -rw-r--r-- | src/intel/perf/gen_perf.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/intel/perf/gen_perf.c b/src/intel/perf/gen_perf.c index 05103acfb21..be7de571ff1 100644 --- a/src/intel/perf/gen_perf.c +++ b/src/intel/perf/gen_perf.c @@ -1999,12 +1999,13 @@ read_oa_samples_until(struct gen_perf_context *perf_ctx, exec_list_push_tail(&perf_ctx->free_sample_buffers, &buf->link); if (len < 0) { - if (errno == EAGAIN) - return ((last_timestamp - start_timestamp) >= + if (errno == EAGAIN) { + return ((last_timestamp - start_timestamp) < INT32_MAX && + (last_timestamp - start_timestamp) >= (end_timestamp - start_timestamp)) ? OA_READ_STATUS_FINISHED : OA_READ_STATUS_UNFINISHED; - else { + } else { DBG("Error reading i915 perf samples: %m\n"); } } else |