summaryrefslogtreecommitdiff
path: root/sql/tztime.cc
diff options
context:
space:
mode:
authorMonty <monty@mariadb.org>2020-05-02 13:19:53 +0300
committerMonty <monty@mariadb.org>2020-05-23 12:29:10 +0300
commit4102f1589c23309de968a5bf9511d3228a1b9319 (patch)
tree9450597fff4a510282b2dec366cb102f5aadfc57 /sql/tztime.cc
parentd1d472646d578608791dcd33c13ca6b2472e31b2 (diff)
downloadmariadb-git-4102f1589c23309de968a5bf9511d3228a1b9319.tar.gz
Aria will now register it's transactions
MDEV-22531 Remove maria::implicit_commit() MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in MYSQL_BIN_LOG::unlog_xa_prepare From the handler point of view, Aria now looks like a transactional engine. One effect of this is that we don't need to call maria::implicit_commit() anymore. This change also forces the server to call trans_commit_stmt() after doing any read or writes to system tables. This work will also make it easier to later allow users to have system tables in other engines than Aria. To handle the case that Aria doesn't support rollback, a new handlerton flag, HTON_NO_ROLLBACK, was added to engines that has transactions without rollback (for the moment only binlog and Aria). Other things - Moved freeing of MARIA_SHARE to a separate function as the MARIA_SHARE can be still part of a transaction even if the table has closed. - Changed Aria checkpoint to use the new MARIA_SHARE free function. This fixes a possible memory leak when using S3 tables - Changed testing of binlog_hton to instead test for HTON_NO_ROLLBACK - Removed checking of has_transaction_manager() in handler.cc as we can assume that as the transaction was started by the engine, it does support transactions. - Added new class 'start_new_trans' that can be used to start indepdendent sub transactions, for example while reading mysql.proc, using help or status tables etc. - open_system_tables...() and open_proc_table_for_Read() doesn't anymore take a Open_tables_backup list. This is now handled by 'start_new_trans'. - Split thd::has_transactions() to thd::has_transactions() and thd::has_transactions_and_rollback() - Added handlerton code to free cached transactions objects. Needed by InnoDB. squash! 2ed35999f2a2d84f1c786a21ade5db716b6f1bbc
Diffstat (limited to 'sql/tztime.cc')
-rw-r--r--sql/tztime.cc13
1 files changed, 9 insertions, 4 deletions
diff --git a/sql/tztime.cc b/sql/tztime.cc
index 72db37fde9c..36f527113ea 100644
--- a/sql/tztime.cc
+++ b/sql/tztime.cc
@@ -2330,16 +2330,21 @@ my_tz_find(THD *thd, const String *name)
else if (time_zone_tables_exist)
{
TABLE_LIST tz_tables[MY_TZ_TABLES_COUNT];
- Open_tables_backup open_tables_state_backup;
+ /*
+ Allocate start_new_trans with malloc as it's > 4000 bytes and this
+ function can be called deep inside a stored procedure
+ */
+ start_new_trans *new_trans= new start_new_trans(thd);
tz_init_table_list(tz_tables);
init_mdl_requests(tz_tables);
- if (!open_system_tables_for_read(thd, tz_tables,
- &open_tables_state_backup))
+ if (!open_system_tables_for_read(thd, tz_tables))
{
result_tz= tz_load_from_open_tables(name, tz_tables);
- close_system_tables(thd, &open_tables_state_backup);
+ thd->commit_whole_transaction_and_close_tables();
}
+ new_trans->restore_old_transaction();
+ delete new_trans;
}
}