diff options
| author | Vicențiu Ciorbaru <vicentiu@mariadb.org> | 2016-03-16 01:14:43 +0200 |
|---|---|---|
| committer | Vicențiu Ciorbaru <vicentiu@mariadb.org> | 2016-03-16 01:14:43 +0200 |
| commit | 350903e95201da90851db513d2d3fac7ba2f324c (patch) | |
| tree | 9133415ba289421ff15334bf6e72f5b8be20b16d /sql/sql_window.cc | |
| parent | 333ac13be547eab0e133603335ecc9368bb10b94 (diff) | |
| download | mariadb-git-350903e95201da90851db513d2d3fac7ba2f324c.tar.gz | |
Remove no longer needed TODO.
Diffstat (limited to 'sql/sql_window.cc')
| -rw-r--r-- | sql/sql_window.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/sql/sql_window.cc b/sql/sql_window.cc index e41207f7e4e..f0d74b15e7c 100644 --- a/sql/sql_window.cc +++ b/sql/sql_window.cc @@ -1261,13 +1261,6 @@ bool compute_window_func_with_frames(Item_window_func *item_win, */ tbl->file->ha_rnd_pos(tbl->record[0], rowid_buf); store_record(tbl,record[1]); - // TODO-cvicentiu - // Save in field does not make use of the null value for the sum function. - // If we do however set the null value to be the same as the one that - // the current sum function has, via say - // item_win->null_value = sum_func->null_value; we get an assertion failure - // during the sending of data within Item::send, in the case of DECIMAL_RESULT. - // How do we force saving of NULL values in the table? item_win->save_in_field(item_win->result_field, true); err= tbl->file->ha_update_row(tbl->record[1], tbl->record[0]); if (err && err != HA_ERR_RECORD_IS_THE_SAME) |