diff options
author | Vicențiu Ciorbaru <cvicentiu@gmail.com> | 2023-02-07 13:57:20 +0200 |
---|---|---|
committer | Vicențiu Ciorbaru <cvicentiu@gmail.com> | 2023-02-09 16:09:08 +0200 |
commit | 08c852026ddaa1ae7717aa31950946c9da457f1f (patch) | |
tree | 71772994945015715929877efae9d4c5af3777a8 /sql/sql_window.cc | |
parent | 8dab66141619f7e6a541a8d4a848596e919e9593 (diff) | |
download | mariadb-git-08c852026ddaa1ae7717aa31950946c9da457f1f.tar.gz |
Apply clang-tidy to remove empty constructors / destructors
This patch is the result of running
run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' .
Code style changes have been done on top. The result of this change
leads to the following improvements:
1. Binary size reduction.
* For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by
~400kb.
* A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb.
2. Compiler can better understand the intent of the code, thus it leads
to more optimization possibilities. Additionally it enabled detecting
unused variables that had an empty default constructor but not marked
so explicitly.
Particular change required following this patch in sql/opt_range.cc
result_keys, an unused template class Bitmap now correctly issues
unused variable warnings.
Setting Bitmap template class constructor to default allows the compiler
to identify that there are no side-effects when instantiating the class.
Previously the compiler could not issue the warning as it assumed Bitmap
class (being a template) would not be performing a NO-OP for its default
constructor. This prevented the "unused variable warning".
Diffstat (limited to 'sql/sql_window.cc')
-rw-r--r-- | sql/sql_window.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/sql_window.cc b/sql/sql_window.cc index bf36b592d96..ff7554b0cd7 100644 --- a/sql/sql_window.cc +++ b/sql/sql_window.cc @@ -948,7 +948,7 @@ protected: class Table_read_cursor : public Rowid_seq_cursor { public: - virtual ~Table_read_cursor() {} + virtual ~Table_read_cursor() = default; void init(READ_RECORD *info) { @@ -1132,7 +1132,7 @@ public: virtual bool is_outside_computation_bounds() const { return false; }; - virtual ~Frame_cursor() {} + virtual ~Frame_cursor() = default; /* Regular frame cursors add or remove values from the sum functions they |