summaryrefslogtreecommitdiff
path: root/sql/sql_prepare.cc
diff options
context:
space:
mode:
authorSergei Golubchik <serg@mariadb.org>2017-01-16 18:23:02 +0100
committerSergei Golubchik <serg@mariadb.org>2017-01-17 20:16:09 +0100
commitef8003eb9a23007ac5d606530dcdcc3ea2f0c039 (patch)
treeb374ac22e4a21b295c378fba316c5b3fa78126d6 /sql/sql_prepare.cc
parente79e840607adff6f2e55d4c889ae055d07bdabf5 (diff)
downloadmariadb-git-ef8003eb9a23007ac5d606530dcdcc3ea2f0c039.tar.gz
MDEV-11698 Old Bug possibly not fixed; BEFORE INSERT Trigger on NOT NULL
check_that_all_fields_are_given_values() relied on write_set, but was run too early, before triggers updated write_set. also, when triggers are present, fields might get values conditionally, so we need to check that all fields are given values for every row.
Diffstat (limited to 'sql/sql_prepare.cc')
-rw-r--r--sql/sql_prepare.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/sql_prepare.cc b/sql/sql_prepare.cc
index d381825851d..d3a5d0aeef6 100644
--- a/sql/sql_prepare.cc
+++ b/sql/sql_prepare.cc
@@ -1299,7 +1299,7 @@ static bool mysql_test_insert(Prepared_statement *stmt,
if (mysql_prepare_insert(thd, table_list, table_list->table,
fields, values, update_fields, update_values,
- duplic, &unused_conds, FALSE, FALSE, FALSE))
+ duplic, &unused_conds, FALSE))
goto error;
value_count= values->elements;