diff options
| author | Brandon Nesterenko <brandon.nesterenko@mariadb.com> | 2021-10-20 20:13:45 -0600 |
|---|---|---|
| committer | Brandon Nesterenko <brandon.nesterenko@mariadb.com> | 2022-01-05 13:41:58 -0700 |
| commit | 515dc593ab47371875434e1de0f77125ce3dc6f4 (patch) | |
| tree | 4daf7500ca090923ceab6d72a5b5e591e58e7851 /sql/sql_class.cc | |
| parent | c18896f9c1ce6e4b9a8519a2d5155698d82ae45a (diff) | |
| download | mariadb-git-bb-10.4-MDEV-11853.tar.gz | |
MDEV-11853: semisync thread can be killed after sync binlog but before ACK in the sync statebb-10.4-MDEV-11853
Problem:
========
If a primary is shutdown during an active semi-sync connection
during the period when the primary is awaiting an ACK, the primary
hard kills the active communication thread and does not ensure the
transaction was received by a replica. This can lead to an
inconsistent replication state.
Solution:
========
During shutdown, the primary should wait for an ACK or timeout
before hard killing a thread which is awaiting a communication. We
extend the `SHUTDOWN WAIT FOR SLAVES` logic to identify and ignore
any threads waiting for a semi-sync ACK in phase 1. Then, before
stopping the ack receiver thread, the shutdown is delayed until all
waiting semi-sync connections receive an ACK or time out. The
connections are then killed in phase 2.
Reviewed By:
============
TODO
Diffstat (limited to 'sql/sql_class.cc')
| -rw-r--r-- | sql/sql_class.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sql/sql_class.cc b/sql/sql_class.cc index 21546ddaebf..03482c6ea69 100644 --- a/sql/sql_class.cc +++ b/sql/sql_class.cc @@ -640,7 +640,8 @@ THD::THD(my_thread_id id, bool is_wsrep_applier) #ifdef HAVE_REPLICATION , current_linfo(0), - slave_info(0) + slave_info(0), + awaiting_semisync_ack(0) #endif #ifdef WITH_WSREP , |