Change replication to use uchar for all buffers instead of char

This change is to get rid of randomly failing tests, especially those
that reads random position of the binary log. From looking at the logs
it's clear that some failures is because of a read char (with value >= 128)
is converted to a big long value. Using uchar everywhere makes this much
less likely to happen.
Another benefit is that a lot of cast of char to uchar could be removed.

Other things:
- Removed some extra space before '=' and '+=' in assignments
- Fixed indentations and lines > 80 characters
- Replace '16' with 'element_size' (from class definition) in
  Gtid_list_log_event()

1 files changed, 2 insertions, 2 deletions

diff --git a/sql/rpl_mi.h b/sql/rpl_mi.h
index 946d138d618..0d6e959838f 100644
--- a/sql/rpl_mi.h
+++ b/sql/rpl_mi.h
@@ -139,8 +139,8 @@ typedef struct st_rows_event_tracker
   my_off_t first_seen;
   my_off_t last_seen;
   bool stmt_end_seen;
-  void update(const char* file_name, my_off_t pos,
-              const char* buf,
+  void update(const char *file_name, my_off_t pos,
+              const uchar *buf,
               const Format_description_log_event *fdle);
   void reset();
   bool check_and_report(const char* file_name, my_off_t pos);