diff options
| author | Rucha Deodhar <rucha.deodhar@mariadb.com> | 2021-08-13 15:49:16 +0530 |
|---|---|---|
| committer | Rucha Deodhar <rucha.deodhar@mariadb.com> | 2022-01-11 15:05:40 +0530 |
| commit | cea4f7439532e1892561a07f7f4e6228eebc0672 (patch) | |
| tree | 0591442cdd1d76cf8e4a568ea253c90834af8dbb /sql/handler.cc | |
| parent | a81c75f5a96697de560325c440e15b909cac113c (diff) | |
| download | mariadb-git-bb-10.8-MDEV-24920.tar.gz | |
MDEV-24920: Merge "old" SQL variable to "old_mode" sql variablebb-10.8-MDEV-24920
Analysis: There are 2 server variables- "old_mode" and "old". "old" is no
longer needed as "old_mode" has replaced it (however still used in some places
in the code). "old_mode" and "old" has same purpose- emulate behavior from
previous MariaDB versions. So they can be merged to avoid confusion.
Fix: Deprecate "old" variable and create another mode for @@old_mode to mimic
behavior of previous "old" variable. Create specific modes for specifix task
that --old sql variable was doing earlier and use the new modes instead.
Diffstat (limited to 'sql/handler.cc')
| -rw-r--r-- | sql/handler.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sql/handler.cc b/sql/handler.cc index 9c4c6287950..aea8f38d71a 100644 --- a/sql/handler.cc +++ b/sql/handler.cc @@ -5783,7 +5783,8 @@ int handler::calculate_checksum() { Field *f= table->field[i]; - if (! thd->variables.old_mode && f->is_real_null(0)) + if (! (thd->variables.old_behavior & OLD_MODE_CHECKSUM_SLOW_NULLS) && + f->is_real_null(0)) { flush_checksum(&row_crc, &checksum_start, &checksum_length); continue; |