MDEV-27462 : SET STATEMENT allows variables that cannot be set per querybb-10.2-MDEV-27462

basis

Analysis: Some system variables can be set per query basis because flag NO_SET_STMT
is missing.
Fix: Added NO_SET_STMT flag. List of disallowed variables taken from
documentation:
autocommit, character_set_client, character_set_connection,
character_set_filesystem, collation_connection, default_master_connection,
debug_sync, interactive_timeout, gtid_domain_id, last_insert_id,
log_slow_filter, log_slow_rate_limit, log_slow_verbosity, long_query_time,
min_examined_row_limit, profiling, profiling_history_size, query_cache_type,
rand_seed1, rand_seed2, skip_replication, slow_query_log, sql_log_off,
tx_isolation, wait_timeout

6 files changed, 192 insertions, 43 deletions

diff --git a/mysql-test/r/set_statement.result b/mysql-test/r/set_statement.result
index cd4859c32e8..44595eef7f8 100644
--- a/mysql-test/r/set_statement.result
+++ b/mysql-test/r/set_statement.result
@@ -1042,13 +1042,28 @@ set global general_log=@save_general_log;
 set @save_long_query_time= @@long_query_time;
 set @save_slow_query_log= @@slow_query_log;
 set @save_log_output= @@log_output;
-set statement long_query_time=default for select @@long_query_time;
+set @old_long_query_time= @@long_query_time;
+set @@long_query_time=default;
+select @@long_query_time;
 @@long_query_time
 DEFAULT
-set statement log_slow_filter=default for select @@log_slow_filter;
-set statement log_slow_verbosity=default for select @@log_slow_verbosity;
-set statement log_slow_rate_limit=default for select @@log_slow_rate_limit;
-set statement slow_query_log=default for select @@slow_query_log;
+set @@long_query_time= @old_long_query_time;
+set @old_log_slow_filter= @@log_slow_filter;
+set @@log_slow_filter=default;
+select @@log_slow_filter;
+set @@log_slow_filter= @old_log_slow_filter;
+set @old_log_slow_verbosity= @@log_slow_verbosity;
+set @@log_slow_verbosity=default;
+select @@log_slow_verbosity;
+set @@log_slow_verbosity= @old_log_slow_verbosity;
+set @old_log_slow_rate_limit= @@log_slow_rate_limit;
+set @@log_slow_rate_limit=default;
+select @@log_slow_rate_limit;
+set @@log_slow_rate_limit= @old_log_slow_rate_limit;
+set @old_slow_query_log= @@slow_query_log;
+set @@slow_query_log=default;
+select @@slow_query_log;
+set @@slow_query_log= @old_slow_query_log;
 truncate table mysql.slow_log;
 set slow_query_log= 1;
 set global log_output='TABLE';
@@ -1065,51 +1080,66 @@ sql_text
 select sleep(0.1)
 #---
 #should be written
-set statement long_query_time=0.01 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time;
+set @@long_query_time=0.01;
+select sleep(0.1);
 sleep(0.1)
 0
+set @@long_query_time=@old_long_query_time;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 sql_text
 select sleep(0.1)
-set statement long_query_time=0.01 for select sleep(0.1)
+select sleep(0.1)
 #---
 set @@long_query_time=0.01;
 #should NOT be written
-set statement slow_query_log=0 for select sleep(0.1);
+set @old_slow_query_log= @@slow_query_log;
+set @@slow_query_log=0;
+select sleep(0.1);
 sleep(0.1)
 0
+set @@slow_query_log=@old_slow_query_log;
 set @@long_query_time=@save_long_query_time;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 sql_text
 select sleep(0.1)
-set statement long_query_time=0.01 for select sleep(0.1)
+select sleep(0.1)
 #---
 #should NOT be written
-set statement long_query_time=0.01,log_slow_filter='full_scan' for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_log_slow_filter=@@log_slow_filter;
+set @@long_query_time=0.01, @@log_slow_filter='full_scan';
+select sleep(0.1);
 sleep(0.1)
 0
+set @@long_query_time= @old_long_query_time, @@log_slow_filter=@old_log_slow_filter;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 sql_text
 select sleep(0.1)
-set statement long_query_time=0.01 for select sleep(0.1)
+select sleep(0.1)
 #---
 #should NOT be written
-set statement long_query_time=0.01,log_slow_rate_limit=9999 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_log_slow_filter=@@log_slow_filter;
+set @@long_query_time=0.01,@@log_slow_rate_limit=9999;
+select sleep(0.1);
 sleep(0.1)
 0
+set @@long_query_time= @old_long_query_time, @@log_slow_filter=@old_log_slow_filter;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 sql_text
 select sleep(0.1)
-set statement long_query_time=0.01 for select sleep(0.1)
+select sleep(0.1)
 #---
 #should NOT be written
-set statement long_query_time=0.01,min_examined_row_limit=50 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_min_examined_row_limit=@@min_examined_row_limit;
+set @@long_query_time=0.01, @@min_examined_row_limit=50;
+select sleep(0.1);
 sleep(0.1)
 0
+set @@long_query_time= @old_long_query_time, @@min_examined_row_limit=@old_min_examined_row_limit;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 sql_text
 select sleep(0.1)
-set statement long_query_time=0.01 for select sleep(0.1)
+select sleep(0.1)
 #---
 set global log_output= @save_log_output;
 set @@slow_query_log= @save_slow_query_log;
@@ -1137,6 +1167,34 @@ set statement wait_timeout=default for select 1;
 ERROR 42000: The system variable wait_timeout cannot be set in SET STATEMENT.
 set statement interactive_timeout=default for select 1;
 ERROR 42000: The system variable interactive_timeout cannot be set in SET STATEMENT.
+set statement default_master_connection='' for select 1;
+ERROR 42000: The system variable default_master_connection cannot be set in SET STATEMENT.
+set statement debug_sync='RESET' for select 1;
+ERROR 42000: The system variable debug_sync cannot be set in SET STATEMENT.
+set statement gtid_domain_id=1 for select 1;
+ERROR 42000: The system variable gtid_domain_id cannot be set in SET STATEMENT.
+set statement last_insert_id=1 for select 1;
+ERROR 42000: The system variable last_insert_id cannot be set in SET STATEMENT.
+set statement log_slow_filter=2 for select 1;
+ERROR 42000: The system variable log_slow_filter cannot be set in SET STATEMENT.
+set statement log_slow_rate_limit=1.1 for select 1;
+ERROR 42000: The system variable log_slow_rate_limit cannot be set in SET STATEMENT.
+set statement log_slow_rate_limit=1.1 for select 1;
+ERROR 42000: The system variable log_slow_rate_limit cannot be set in SET STATEMENT.
+set statement log_slow_verbosity=2 for select 1;
+ERROR 42000: The system variable log_slow_verbosity cannot be set in SET STATEMENT.
+set statement long_query_time=2 for select 1;
+ERROR 42000: The system variable long_query_time cannot be set in SET STATEMENT.
+set statement min_examined_row_limit=65535 for select 1;
+ERROR 42000: The system variable min_examined_row_limit cannot be set in SET STATEMENT.
+set statement profiling=ON for select 1;
+ERROR 42000: The system variable profiling cannot be set in SET STATEMENT.
+set statement rand_seed1=1 for select 1;
+ERROR 42000: The system variable rand_seed1 cannot be set in SET STATEMENT.
+set statement rand_seed2=1 for select 1;
+ERROR 42000: The system variable rand_seed2 cannot be set in SET STATEMENT.
+set statement slow_query_log='OFF' for select 1;
+ERROR 42000: The system variable slow_query_log cannot be set in SET STATEMENT.
 set @save_week_format=@@default_week_format;
 set @@default_week_format=0;
 SET STATEMENT default_week_format = 2 FOR SELECT WEEK('2000-01-01');
diff --git a/mysql-test/r/set_statement_notembedded_binlog.result b/mysql-test/r/set_statement_notembedded_binlog.result
index 50fcde5a1cb..aaf3a57cdfb 100644
--- a/mysql-test/r/set_statement_notembedded_binlog.result
+++ b/mysql-test/r/set_statement_notembedded_binlog.result
@@ -8,14 +8,17 @@ reset master;
 create table t1 (i int);
 set gtid_domain_id = 10;
 insert into t1 values (1),(2);
-set statement gtid_domain_id = 20 for insert into t1 values (3),(4);
+set @old_gtid_domain_id= @@gtid_domain_id;
+set @@gtid_domain_id= 20;
+insert into t1 values (3),(4);
+set @@gtid_domain_id= @old_gtid_domain_id;
 show binlog events limit 5,5;
 Log_name	Pos	Event_type	Server_id	End_log_pos	Info
 x	x	x	x	x	BEGIN GTID 10-1-1
 x	x	x	x	x	use `test`; insert into t1 values (1),(2)
 x	x	x	x	x	COMMIT
 x	x	x	x	x	BEGIN GTID 20-1-1
-x	x	x	x	x	use `test`; set statement gtid_domain_id = 20 for insert into t1 values (3),(4)
+x	x	x	x	x	use `test`; insert into t1 values (3),(4)
 drop table t1;
 reset master;
 SET @a=11;
@@ -24,8 +27,11 @@ create table t2 (b int);
 insert into t2 values (1),(2);
 CREATE function f1() returns int
 BEGIN
-SET STATEMENT last_insert_id=@a for insert into t1 values (NULL, @a,
-last_insert_id());
+declare old_last_insert_id int;
+set old_last_insert_id= @@last_insert_id;
+set last_insert_id= @a;
+insert into t1 values (NULL, @a, last_insert_id());
+set @@last_insert_id= old_last_insert_id;
 SET @a:=@a*100+13;
 return @a;
 end|
@@ -44,12 +50,10 @@ Log_name	Pos	Event_type	Server_id	End_log_pos	Info
 x	x	x	x	x	LAST_INSERT_ID=0
 x	x	x	x	x	INSERT_ID=1
 x	x	x	x	x	@`a`=11
-x	x	x	x	x	@`a`=11
 x	x	x	x	x	use `test`; SELECT `test`.`f1`()
 x	x	x	x	x	LAST_INSERT_ID=0
 x	x	x	x	x	INSERT_ID=2
 x	x	x	x	x	@`a`=1113
-x	x	x	x	x	@`a`=1113
 x	x	x	x	x	use `test`; SELECT `test`.`f1`()
 x	x	x	x	x	COMMIT
 select * from t1;
@@ -101,7 +105,10 @@ a	c	d
 drop function f1;
 drop table t1,t2;
 reset master;
-set statement last_insert_id = 112 for create table t1 as select last_insert_id();
+set @old_last_insert_id= @@last_insert_id;
+set @@last_insert_id= 112;
+create table t1 as select last_insert_id();
+set @@last_insert_id= @old_last_insert_id;
 show binlog events limit 4,1;
 Log_name	Pos	Event_type	Server_id	End_log_pos	Info
 x	x	x	x	x	LAST_INSERT_ID=112
diff --git a/mysql-test/suite/rpl/r/rpl_set_statement_default_master.result b/mysql-test/suite/rpl/r/rpl_set_statement_default_master.result
index 828e171548d..625ab03b419 100644
--- a/mysql-test/suite/rpl/r/rpl_set_statement_default_master.result
+++ b/mysql-test/suite/rpl/r/rpl_set_statement_default_master.result
@@ -4,15 +4,20 @@ connection slave;
 include/stop_slave.inc
 RESET SLAVE ALL;
 # Does not work for CHANGE MASTER:
-SET STATEMENT default_master_connection = 'm1' FOR 
+SET @old_default_master_connection= @@default_master_connection;
+SET default_master_connection = 'm1';
 CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_PORT=MASTER_MYPORT, MASTER_USER='root';
+SET @@default_master_connection= @old_default_master_connection;
 #
 # The first field, Connection_name, should say 'm1'...
 #
 Connection_name = 'm1'
 RESET SLAVE ALL;
 CHANGE MASTER 'm1' TO MASTER_HOST='127.0.0.1', MASTER_PORT=MASTER_MYPORT, MASTER_USER='root';
-SET STATEMENT default_master_connection = 'm1' FOR START SLAVE;
+SET @old_default_master_connection= @@default_master_connection;
+SET default_master_connection = 'm1';
+START SLAVE;
+SET @@default_master_connection= @old_default_master_connection;
 set default_master_connection = 'm1';
 stop slave;
 include/wait_for_slave_to_stop.inc
diff --git a/mysql-test/suite/rpl/t/rpl_set_statement_default_master.test b/mysql-test/suite/rpl/t/rpl_set_statement_default_master.test
index 106cb4547f4..f3451e34869 100644
--- a/mysql-test/suite/rpl/t/rpl_set_statement_default_master.test
+++ b/mysql-test/suite/rpl/t/rpl_set_statement_default_master.test
@@ -6,10 +6,11 @@
 RESET SLAVE ALL;
 
 --echo # Does not work for CHANGE MASTER:
+SET @old_default_master_connection= @@default_master_connection;
+SET default_master_connection = 'm1';
 --replace_result $MASTER_MYPORT MASTER_MYPORT
-eval SET STATEMENT default_master_connection = 'm1' FOR 
-  CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_PORT=$MASTER_MYPORT, MASTER_USER='root';
-
+eval CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_PORT=$MASTER_MYPORT, MASTER_USER='root';
+SET @@default_master_connection= @old_default_master_connection;
 
 --echo #
 --echo # The first field, Connection_name, should say 'm1'...
@@ -23,7 +24,10 @@ RESET SLAVE ALL;
 
 --replace_result $MASTER_MYPORT MASTER_MYPORT
 eval CHANGE MASTER 'm1' TO MASTER_HOST='127.0.0.1', MASTER_PORT=$MASTER_MYPORT, MASTER_USER='root';
-SET STATEMENT default_master_connection = 'm1' FOR START SLAVE;
+SET @old_default_master_connection= @@default_master_connection;
+SET default_master_connection = 'm1';
+START SLAVE;
+SET @@default_master_connection= @old_default_master_connection;
 
 set default_master_connection = 'm1';
 stop slave;
diff --git a/mysql-test/t/set_statement.test b/mysql-test/t/set_statement.test
index a5f5c03098d..2edb396c167 100644
--- a/mysql-test/t/set_statement.test
+++ b/mysql-test/t/set_statement.test
@@ -992,15 +992,34 @@ set @save_slow_query_log= @@slow_query_log;
 set @save_log_output= @@log_output;
 
 let $long_query_time=`select @@long_query_time`;
+set @old_long_query_time= @@long_query_time;
+set @@long_query_time=default;
 --replace_result $long_query_time DEFAULT
-set statement long_query_time=default for select @@long_query_time;
+select @@long_query_time;
+set @@long_query_time= @old_long_query_time;
 
 # Disable result log as the results depends on the values of the variables
 --disable_result_log
-set statement log_slow_filter=default for select @@log_slow_filter;
-set statement log_slow_verbosity=default for select @@log_slow_verbosity;
-set statement log_slow_rate_limit=default for select @@log_slow_rate_limit;
-set statement slow_query_log=default for select @@slow_query_log;
+set @old_log_slow_filter= @@log_slow_filter;
+set @@log_slow_filter=default;
+select @@log_slow_filter;
+set @@log_slow_filter= @old_log_slow_filter;
+
+set @old_log_slow_verbosity= @@log_slow_verbosity;
+set @@log_slow_verbosity=default;
+select @@log_slow_verbosity;
+set @@log_slow_verbosity= @old_log_slow_verbosity;
+
+set @old_log_slow_rate_limit= @@log_slow_rate_limit;
+set @@log_slow_rate_limit=default;
+select @@log_slow_rate_limit;
+set @@log_slow_rate_limit= @old_log_slow_rate_limit;
+
+set @old_slow_query_log= @@slow_query_log;
+set @@slow_query_log=default;
+select @@slow_query_log;
+set @@slow_query_log= @old_slow_query_log;
+
 --enable_result_log
 
 truncate table mysql.slow_log;
@@ -1015,25 +1034,41 @@ set @@long_query_time=@save_long_query_time;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 --echo #should be written
-set statement long_query_time=0.01 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time;
+set @@long_query_time=0.01;
+select sleep(0.1);
+set @@long_query_time=@old_long_query_time;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 set @@long_query_time=0.01;
 --echo #should NOT be written
-set statement slow_query_log=0 for select sleep(0.1);
+set @old_slow_query_log= @@slow_query_log;
+set @@slow_query_log=0;
+select sleep(0.1);
+set @@slow_query_log=@old_slow_query_log;
+
 set @@long_query_time=@save_long_query_time;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 --echo #should NOT be written
-set statement long_query_time=0.01,log_slow_filter='full_scan' for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_log_slow_filter=@@log_slow_filter;
+set @@long_query_time=0.01, @@log_slow_filter='full_scan';
+select sleep(0.1);
+set @@long_query_time= @old_long_query_time, @@log_slow_filter=@old_log_slow_filter;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 --echo #should NOT be written
-set statement long_query_time=0.01,log_slow_rate_limit=9999 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_log_slow_filter=@@log_slow_filter;
+set @@long_query_time=0.01,@@log_slow_rate_limit=9999;
+select sleep(0.1);
+set @@long_query_time= @old_long_query_time, @@log_slow_filter=@old_log_slow_filter;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 --echo #should NOT be written
-set statement long_query_time=0.01,min_examined_row_limit=50 for select sleep(0.1);
+set @old_long_query_time= @@long_query_time, @old_min_examined_row_limit=@@min_examined_row_limit;
+set @@long_query_time=0.01, @@min_examined_row_limit=50;
+select sleep(0.1);
+set @@long_query_time= @old_long_query_time, @@min_examined_row_limit=@old_min_examined_row_limit;
 select sql_text from mysql.slow_log where sql_text not like 'set @@long_query_time%';
 --echo #---
 #
@@ -1072,6 +1107,34 @@ set statement query_cache_type=default for select 1;
 set statement wait_timeout=default for select 1;
 --error ER_SET_STATEMENT_NOT_SUPPORTED
 set statement interactive_timeout=default for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement default_master_connection='' for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement debug_sync='RESET' for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement gtid_domain_id=1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement last_insert_id=1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement log_slow_filter=2 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement log_slow_rate_limit=1.1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement log_slow_rate_limit=1.1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement log_slow_verbosity=2 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement long_query_time=2 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement min_examined_row_limit=65535 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement profiling=ON for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement rand_seed1=1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement rand_seed2=1 for select 1;
+--error ER_SET_STATEMENT_NOT_SUPPORTED
+set statement slow_query_log='OFF' for select 1;
 
 # MDEV-6996: SET STATEMENT default_week_format = .. has no effect
 set @save_week_format=@@default_week_format;
@@ -1128,7 +1191,10 @@ let $1=10;
 while ($1)
 {
   --disable_result_log
-  set statement rand_seed1=1, rand_seed2=1 for select 1;
+  set @old_rand_seed1= @@rand_seed1, @old_rand_seed2=@@rand_seed2;
+  set @@rand_seed1=1, @@rand_seed2=1;
+  select 1;
+  set @@rand_seed1=@old_rand_seed1, @@rand_seed2=@old_rand_seed2;
   --enable_result_log
   set @rnd= rand()=0 and @rnd;
   dec $1;
diff --git a/mysql-test/t/set_statement_notembedded_binlog.test b/mysql-test/t/set_statement_notembedded_binlog.test
index b0c00008d4f..e58da080429 100644
--- a/mysql-test/t/set_statement_notembedded_binlog.test
+++ b/mysql-test/t/set_statement_notembedded_binlog.test
@@ -15,7 +15,10 @@ reset master;
 create table t1 (i int);
 set gtid_domain_id = 10;
 insert into t1 values (1),(2);
-set statement gtid_domain_id = 20 for insert into t1 values (3),(4);
+set @old_gtid_domain_id= @@gtid_domain_id;
+set @@gtid_domain_id= 20;
+insert into t1 values (3),(4);
+set @@gtid_domain_id= @old_gtid_domain_id;
 
 --replace_column 1 x 2 x 3 x 4 x 5 x
 show binlog events limit 5,5;
@@ -32,8 +35,11 @@ insert into t2 values (1),(2);
 DELIMITER |;
 CREATE function f1() returns int
 BEGIN
-  SET STATEMENT last_insert_id=@a for insert into t1 values (NULL, @a,
-  last_insert_id());
+  declare old_last_insert_id int;
+  set old_last_insert_id= @@last_insert_id;
+  set last_insert_id= @a;
+  insert into t1 values (NULL, @a, last_insert_id());
+  set @@last_insert_id= old_last_insert_id;
   SET @a:=@a*100+13;
   return @a;
 end|
@@ -82,7 +88,10 @@ drop function f1;
 drop table t1,t2;
 
 reset master;
-set statement last_insert_id = 112 for create table t1 as select last_insert_id();
+set @old_last_insert_id= @@last_insert_id;
+set @@last_insert_id= 112;
+create table t1 as select last_insert_id();
+set @@last_insert_id= @old_last_insert_id;
 --replace_column 1 x 2 x 3 x 4 x 5 x
 show binlog events limit 4,1;
 drop table t1;