summaryrefslogtreecommitdiff
path: root/myisam/mi_rkey.c
diff options
context:
space:
mode:
authorunknown <monty@mysql.com>2005-10-07 03:12:15 +0300
committerunknown <monty@mysql.com>2005-10-07 03:12:15 +0300
commit02c4a2112b33f9bcce06857507ba1661c6181577 (patch)
treef958b70fe8b350986e02f3c229c7f0b5c766ad77 /myisam/mi_rkey.c
parent154374c19a43c95f5e0557b9f4304931878bfb0a (diff)
downloadmariadb-git-02c4a2112b33f9bcce06857507ba1661c6181577.tar.gz
Review of new code since last pull
- Use %lx instead of %p as %p is not portable - Don't replace ROW item with Item_null myisam/mi_rkey.c: Use %lx instead of %p as %p is not portable myisam/mi_search.c: Use %lx instead of %p as %p is not portable mysql-test/r/select.result: More test for ROW comparison mysql-test/t/select.test: More test for ROW comparison sql/item.cc: We can't replace a ROW item with Item_null because: - Arg_comparator is still using the orignal row items and it's not good to have args[0] different from what is actually compared - If we are using the <=> comparator, NULL can still be compared as true - We would break things if we would ever use resolve_const_item() for operators like >, < etc.
Diffstat (limited to 'myisam/mi_rkey.c')
-rw-r--r--myisam/mi_rkey.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/myisam/mi_rkey.c b/myisam/mi_rkey.c
index 9aa2be3c706..de4cefb19b6 100644
--- a/myisam/mi_rkey.c
+++ b/myisam/mi_rkey.c
@@ -31,8 +31,8 @@ int mi_rkey(MI_INFO *info, byte *buf, int inx, const byte *key, uint key_len,
HA_KEYSEG *last_used_keyseg;
uint pack_key_length, use_key_length, nextflag;
DBUG_ENTER("mi_rkey");
- DBUG_PRINT("enter", ("base: %p buf: %p inx: %d search_flag: %d",
- info, buf, inx, search_flag));
+ DBUG_PRINT("enter", ("base: %lx buf: %lx inx: %d search_flag: %d",
+ (long) info, (long) buf, inx, search_flag));
if ((inx = _mi_check_index(info,inx)) < 0)
DBUG_RETURN(my_errno);