summaryrefslogtreecommitdiff
path: root/function.c
Commit message (Collapse)AuthorAgeFilesLines
* Fix bs-nl handling, exit and Environment for VMS.John Malmberg2015-01-271-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fix required a complete rewrite of the command parser vmsjobs.c child_execute_job. The old parser had too many incorrect assumptions about DCL commands and could not be repaired to extended. The parser now more closely parses VMS commands and handles quoted commands and redirection. Command File mode has been improved, but can not fully support bs-nl syntax. VMS Unix shell simulation has been improved. * commands.c: vms_comma_separator is now a run-time setting. * function.c: vms_comma_separator is now a run-time setting. * function.c(func_basename_dir) now reports "[]" or "./" based on VMS crtl runtime setting. * job.c(start_job_command): VMS Handle empty commands propery. * main.c: Add VMS environment variables for run-time settings. * vms_legacy_behavior - Force older behavior. * vms_comma_separator - Commas or spaces for separators. * vms_unix_simulation - Enhanced Posix shell simulation features. * Detect if VMS CRTL is set to report Unix paths instead of VMS. * ':' and '>' are also MAP_DIRSEP on VMS. * makeint.h: Add VMS run-time option variables. * readme.vms: Update to current behavior. * variable.c(define_variable_in_set): Fix VMS Environment variable lookup. * variable.c(define_automatic_variables): Remove some VMS specific automatic variables and use the Unix ones instead. * vms_export_symbol.c: Set max symbol size correctly. * vmsjobs.c: child_execute_job() complete rewrite of VMS comand parsing. * vmsjobs.c(build_vms_cmd): VMS commmand building with shell simulation. Signed-off-by: Paul Smith <psmith@gnu.org>
* Fix $(shell) on hosts with 64-bit pid_t.Christian Boos2014-12-271-1/+2
| | | | | | | * function.c: Use pid_t for shell_function_pid. * job.c: Likewise. Copyright-paperwork-exempt: yes
* Treat redirection of standard handles on Windows as it is done on Unix.Eli Zaretskii2014-10-011-3/+3
| | | | | | | | | | * job.c (start_job_command) [WINDOWS32]: Compute outfd and errfd as on Posix platforms, and pass the results to process_easy. * function.c (windows32_openpipe) [WINDOWS32]: Accept an additional argument ERRFD and use it for redirecting the standard error handle passed to the subprocess. (func_shell_base) [WINDOWS32]: Pass the computed errfd to windows32_openpipe.
* Fix VMS automatic variable expansionHartmut Becker2014-09-071-1/+39
| | | | | | * function.c: add VMS code to func_notdir_suffix and func_basename_dir to work on comma separated lists; this fixes the expansion of $(^D), $(+D) and the F variants for VMS.
* Enhance/fix VMS exit code handling.Hartmut Becker2014-09-071-1/+1
| | | | | | | | * commands.c, function.c, hash.c, job.c, main.c, output.c: use MAKE exit codes. * makeint.h: encode make exit codes so that they are VMS compatible. * job.c: check child exit code for VMS style exit codes. * vmsjobs.c: save and return VMS style exit code.
* * various: Assume ISO C89-compliant free() implementation.Paul Smith2014-07-071-1/+1
|
* [SV 41983] Support omitting the text argument to $(file ...)Paul Smith2014-07-071-3/+3
| | | | | | | | Reported by Tim Murphy <tnmurphy@gmail.com> * function.c (func_file): Only write TEXT if it is not NULL. * NEWS, doc/make.texi: Document the new feature * tests/scripts/functions/file: Verify that the no-text version of $(file ...) works and doesn't add a newline.
* * Rename MAP_PATHSEP to MAP_DIRSEP.Paul Smith2014-02-081-12/+12
|
* [SV 40361] Don't use vsnprintf(), which is an ISO C99 function.Paul Smith2013-11-231-28/+35
| | | | | | | | | | * output.c (error, fatal, message): Take an extra argument specifying how many bytes are used by the formatted arguments. (get_buffer): New function that allocates the requested buffer size. Remove msc_vsnprintf(), vfmtconcat(), and fmtconcat() as unneeded. * makeint.h: Declare various helper macros for generating output. * *.c: Change all error(), fatal(), message() calls to use the macros, or pass the extra length argument directly.
* Sanitize the registered function interface.Paul Smith2013-10-051-18/+27
| | | | | | Expand the characters which are legal in a function name, and check the name for validity. Create a type for the function pointer. Convert the last argument from a boolean to flags, to allow for expansion.
* function.c (abspath): Reset root_len to one for Cygwin only whenEli Zaretskii2013-10-031-1/+1
| | | | HAVE_DOS_PATHS is defined. Suggested by Christopher Faylor.
* Fix $abspath on Cygwin when HAVE_DOS_PATHS is in effect.Eli Zaretskii2013-10-021-4/+12
| | | | | | | function.c (IS_ABSOLUTE) [__CYGWIN__]: Special definition for Cygwin. (abspath) [__CYGWIN__]: Reset root_len to 1 if the absolute file name has the Posix /foo/bar form. [HAVE_DOS_PATHS]: Use root_len instead of hard-coded 2.
* Final fixes for obscure output-sync errors.Paul Smith2013-09-301-7/+8
|
* Fix build failures on EMX for output-sync support.Paul Smith2013-09-291-7/+7
|
* Ensure that stderr from shell functions in recipes is synced.Paul Smith2013-09-211-4/+6
|
* [SV 39851] Reinstate stack size limit for processes spawned via $(shell)Petr Machata2013-09-141-1/+8
|
* Support the -Orecurse option properly.Paul Smith2013-09-141-1/+1
| | | | | | | | In this mode we still collect all the output from a given target and dump it at once. However we don't treat recursive lines any differently from non-recursive lines. Also we don't print enter/leave messages after every dump. However we do ensure that we always print them once to stdout, so the parent make will collect it properly.
* Enhance the output sync mode.Paul Smith2013-09-121-2/+5
| | | | | | | | | | | | | | | Create a new file, output.c, and collect functions that generate output there. We introduce a new global context specifying where output should go (to stdout or to a sync file), and the lowest level output generator chooses where to write output based on that context. This allows us to set the context globally, and all operations that write output (including functions like $(info ...) etc.) will use it. Removed the "--trace=dir" capability. It was too confusing. If you have directory tracking enabled then output sync will print the enter/leave message for each synchronized block. If you don't want that, disable directory tracking.
* [Bug #39158] Source cleanups suggested by cppcheck utility.Paul Smith2013-07-211-2/+3
|
* Create a character map to use for locating stop-points in strings.Paul Smith2013-06-221-36/+19
| | | | | | | | | In various places we were passing flags and characters to compare, then using complex conditionals to see where to stop in string searches. Performance numbers reveal that we were spending as much as 23% of our processing time in these functions, most of it in the comparison lines. Instead create a character map and use a single bitwise comparison to determine if this is any one of the stop characters.
* Porting to VMS, from Hartmut Becker.Paul Smith2013-05-271-0/+1
|
* Update source file format: remove TABs, use GNU coding styles.Paul Smith2013-05-171-338/+337
|
* Update copyright for changes in 2013.Paul Smith2013-05-171-1/+1
|
* cosmetics: fix few innocuous typosStefano Lattarini2013-05-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Most of these were found using Lucas De Marchi's 'codespell' tool. * ChangeLog: Fix minor typos. * ChangeLog.2: Likewise. * README.Amiga: Likewise. * TODO.private: Likewise. * function.c: Likewise. * glob/glob.h: Likewise. * job.c: Likewise. * main.c: Likewise. * readme.vms: Likewise. * remake.c: Likewise. * tests/ChangeLog: Likewise. * tests/NEWS: Likewise. * tests/README: Likewise. * tests/scripts/variables/private: Likewise. * vmsdir.h: Likewise. * signame.c: Likewise. While at it, improve line wrapping in the touched comment. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* Support --output-sync on MS-Windows.Eli Zaretskii2013-04-271-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | w32/compat/posixfcn.c: New file, with emulations of Posix functions and Posix functionality for MS-Windows. w32/subproc/sub_proc.c: Include io.h. (process_noinherit): New function, forces a file descriptor to not be inherited by child processes. (process_easy): Accept two additional arguments, and use them to set up the standard output and standard error handles of the child process. w32/include/sub_proc.h (process_easy): Adjust prototype. (process_noinherit): Add prototype. read.c [WINDOWS32]: Include windows.h and sub_proc.h. makeint.h (LOCALEDIR) [WINDOWS32}: Define to NULL if not defined. This is needed because the MS-Windows build doesn't have a canonical place for LOCALEDIR. (WIN32_LEAN_AND_MEAN) [WINDOWS32]: Define, to avoid getting from windows.h header too much stuff that could conflict with the code. main.c <sync_mutex>: New static variable. <switches>: Add support for "--sync-mutex" switch. (decode_output_sync_flags): Decode the --sync-mutex= switch. (prepare_mutex_handle_string) [WINDOWS32]: New function. (main): Add "output-sync" to .FEATURES. job.h (CLOSE_ON_EXEC) [WINDOWS32]: Define to call process_noinherit. (F_GETFD, F_SETLKW, F_WRLCK, F_UNLCK, struct flock) [WINDOWS32]: New macros. (RECORD_SYNC_MUTEX): New macro, a no-op for Posix platforms. (sync_handle_t): New typedef. job.c <sync_handle>: Change type to sync_handle_t. (FD_NOT_EMPTY): Seek to the file's end. Suggested by Frank Heckenbach <f.heckenbach@fh-soft.de>. (pump_from_tmp_fd) [WINDOWS32]: Switch to_fd to binary mode for the duration of this function, and then change back before returning. (start_job_command) [WINDOWS32]: Support output_sync mode on MS-Windows. Use a system-wide mutex instead of locking stdout/stderr. Call process_easy with two additional arguments: child->outfd and child->errfd. (exec_command) [WINDOWS32]: Pass two additional arguments, both -1, to process_easy, to adjust for the changed function signature. function.c (windows32_openpipe) [WINDOWS32]: This function now returns an int, which is -1 if it fails and zero otherwise. It also calls 'error' instead of 'fatal', to avoid exiting prematurely. (func_shell_base) [WINDOWS32]: Call perror_with_name if windows32_openpipe fails, now that it always returns. This avoids a compiler warning that error_prefix is not used in the MS-Windows build. config.h.W32.template (OUTPUT_SYNC): Define. build_w32.bat: Add w32/compat/posixfcn.c to compilation and linking commands. From Frank Heckenbach <f.heckenbach@fh-soft.de>: job.c (sync_output): Don't discard the output if acquire_semaphore fails; instead, dump the output unsynchronized.
* Use ENULLLOOP to handle EINTR during realpath(). Fixes Savannah bug #38420Paul Smith2013-02-281-13/+21
|
* Expand the loadable object support.Paul Smith2013-02-251-51/+74
| | | | | | | Provide a simple API for loaded objects to interact with GNU make. I still won't guarantee that this API won't change but it's much closer to something that's supported and provides easy-to-use interfaces with a public header file.
* Rename struct floc to typedef gmk_floc as an externally scoped symbol.Paul Smith2013-01-201-1/+1
|
* Rename the make.h file to makeint.h for internal use only.Paul Smith2013-01-201-2/+2
|
* On BSD, realpath(3) doesn't fail if the target doesn't exist, so testPaul Smith2012-09-091-4/+2
| | | | explicitly with stat(2). Fixes Savannah bug #35919.
* Simplify copyrights using ranges of years.Paul Smith2012-03-051-3/+1
| | | | | The new GNU Maintainer's Manual allows the use of year ranges in certain situations; take advantage of this simplification.
* Create a new CSTRLEN (constant string length) macro, and use it.Paul Smith2012-03-041-10/+10
|
* Convert all "`'" quotes to "''" per new GNU Coding Standard guidelines.Paul Smith2012-03-041-15/+15
| | | | Fixes Savannah bug #34530.
* Fix Savannah bug #35410: handle escape chars in filter/filter-outPaul Smith2012-03-031-8/+7
| | | | Also add a valgrind suppression file for Guile-enabled make.
* Create a new function $(file ...)Paul Smith2012-01-291-0/+40
|
* Fix failures on MS-Windows when Make's standard handles are invalid.Eli Zaretskii2012-01-281-19/+54
| | | | | | | | | | | | | | | | | | | | | This can happen when Make is invoked from a GUI application. * w32/subproc/sub_proc.c (process_init_fd): Don't dereference pproc if it is a NULL pointer. (process_begin, process_cleanup): Don't try to close pipe handles whose value is INVALID_HANDLE_VALUE. (process_easy): Initialize hIn, hOut, and hErr to INVALID_HANDLE_VALUE. If DuplicateHandle fails with ERROR_INVALID_HANDLE, duplicate a handle for the null device instead of STD_INPUT_HANDLE, STD_OUTPUT_HANDLE or STD_ERROR_HANDLE. Don't try to close pipe handles whose value is INVALID_HANDLE_VALUE. * function.c (windows32_openpipe): Initialize hIn and hErr to INVALID_HANDLE_VALUE. If DuplicateHandle fails with ERROR_INVALID_HANDLE, duplicate a handle for the null device instead of STD_INPUT_HANDLE or STD_ERROR_HANDLE. Fix indentation. Don't try to close handles whose value is INVALID_HANDLE_VALUE.
* function.c (define_new_function): Fix format strings in calls to `fatal'.Eli Zaretskii2012-01-251-2/+2
|
* Create a new internal interface for defining new make functions.Paul Smith2012-01-161-18/+27
| | | | | | | | | This allows us to create new functions without changing function.c. You still have to modify the GNU make code (for now) though: this is simply a preliminary step to possibly allowing make to load modules. Modify the Guile integration to use this method rather than ifdefs in function.c.
* Update copyright notices.Paul Smith2012-01-161-3/+3
|
* Add GNU Guile as an optional embedded scripting language for make.Paul Smith2012-01-151-0/+18
| | | | | | | | | On configure-enabled systems, configure will detect Guile installed (using pkg-config, which is how GNU Guile is distributed) and enable it if so. On all non-configure-enabled systems, currently, the default is for Guile support to be disabled.
* Changes to resolve warnings.Paul Smith2011-11-141-1/+1
| | | | Fixes Savannah bug #34608.
* Use the same algorithm for counting the number of words to sort as wePaul Smith2011-05-021-12/+5
| | | | | use to break up the list of words, so we're sure to get the same number. Fixes Savannah bug #33125
* Add new feature: != shell assignment for portability with BSD make.Paul Smith2011-04-181-9/+27
| | | | Feature submitted by David Wheeler.
* function.c (func_shell) [WINDOWS32]: Reset just_print_flagEli Zaretskii2010-08-071-3/+18
| | | | | | around the call to construct_command_argv, so that a temporary batch file _is_ created when needed for $(shell). Fixes Savannah bug #16362.
* Update copyrights for 2010.Paul Smith2010-07-131-2/+2
|
* Fix Savannah bug #30312.Eli Zaretskii2010-07-091-0/+7
| | | | function.c (abspath): Support absolute file names in UNC format.
* job.c (pid2str) [WINDOWS32]: Don't use %Id with GCC < 4.x.Eli Zaretskii2010-07-091-6/+6
| | | | | | | | | | | | | | | | | | | (exec_command) [WINDOWS32]: Use pid2str instead of non-portable %Id. main.c (handle_runtime_exceptions): Use %p to print addresses, to DTRT on both 32-bit and 64-bit hosts. Savannah bug #27809. job.c (w32_kill, start_job_command, create_batch_file): Use pid_t for process IDs and intptr_t for the 1st arg of _open_osfhandle. function.c (windows32_openpipe): Use pid_t for process IDs and intptr_t for the 1st arg of _open_osfhandle. (func_shell): Use pid_t for process IDs. main.c (main) [WINDOWS32]: Pacify the compiler. config.h.W32.template (pid_t): Add a definition for 64-bit Windows builds that don't use GCC. Savannah bug #27809. Patch by Ozkan Sezer <sezeroz@gmail.com>
* Update copyright years.Paul Smith2009-10-251-2/+2
|
* - Include <alloca.h> even on non-__GNUC__ systems.Paul Smith2009-10-031-1/+2
| | | | - Add some tests for unresolved bugs.
* Fix some memory leaks, found with valgrind.Paul Smith2009-09-261-0/+1
|