summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Gerecke <jason.gerecke@wacom.com>2022-01-04 13:54:46 -0800
committerPeter Hutterer <peter.hutterer@who-t.net>2022-02-22 10:41:51 +1000
commitef372acece43c5cce16e61795a15050a5bcb1726 (patch)
tree0c34148bc437b5a4d8946544a2c6de86b9712938
parentcd02945a778132bcb63db5afec9747a15ade0033 (diff)
downloadxf86-input-wacom-ef372acece43c5cce16e61795a15050a5bcb1726.tar.gz
Misc. unsigned warning fixes
Address a few more unsigned changes that don't fit in elsewhere. Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
-rw-r--r--src/WacomInterface.h7
-rw-r--r--src/wcmConfig.c2
-rw-r--r--tools/tools-shared.c2
3 files changed, 7 insertions, 4 deletions
diff --git a/src/WacomInterface.h b/src/WacomInterface.h
index dc3656f..79a7e50 100644
--- a/src/WacomInterface.h
+++ b/src/WacomInterface.h
@@ -198,12 +198,15 @@ static inline void wcmAxisValue(const WacomAxisData *data,
char *buf, size_t len)
{
int val = 0;
+ int rc;
if (!wcmAxisGet(data, which, &val)) {
- assert(snprintf(buf, len, "N/A") < len);
+ rc = snprintf(buf, len, "N/A");
+ assert(rc > 0 && (size_t)rc < len);
return;
}
- assert(snprintf(buf, len, "%d", val) < len);
+ rc = snprintf(buf, len, "%d", val);
+ assert(rc > 0 && (size_t)rc < len);
}
static inline const char* wcmAxisName(enum WacomAxisType which)
diff --git a/src/wcmConfig.c b/src/wcmConfig.c
index ed65de8..f7abe8b 100644
--- a/src/wcmConfig.c
+++ b/src/wcmConfig.c
@@ -1227,7 +1227,7 @@ TEST_CASE(test_flag_set)
for (size_t i = 0; i < sizeof(flags); i++)
{
- int mask = 1 << i;
+ unsigned int mask = 1 << i;
flags = 0;
assert(!MaskIsSet(flags, mask));
diff --git a/tools/tools-shared.c b/tools/tools-shared.c
index 137bc02..98db0fa 100644
--- a/tools/tools-shared.c
+++ b/tools/tools-shared.c
@@ -113,7 +113,7 @@ int set_serial_attr(int fd, unsigned int baud)
int write_to_tablet(int fd, const char *command)
{
- int len = 0;
+ unsigned long len = 0;
do {
int l;