summaryrefslogtreecommitdiff
path: root/sound/soc/sh/Makefile
diff options
context:
space:
mode:
authorDouglas Anderson <dianders@chromium.org>2021-08-11 08:17:56 -0700
committerMark Brown <broonie@kernel.org>2021-08-12 12:19:17 +0100
commit772d44526e203c062171786e514373f129616278 (patch)
tree54eaed6c6d2397a7c5cf029c0287722a6009ef43 /sound/soc/sh/Makefile
parenteb7ab747efd600382bc2e9406ea1fc2a867e9804 (diff)
downloadlinux-772d44526e203c062171786e514373f129616278.tar.gz
ASoC: rt5682: Properly turn off regulators if wrong device ID
When I booted up on a board that had a slightly different codec stuffed on it, I got this message at bootup: rt5682 9-001a: Device with ID register 6749 is not rt5682 That's normal/expected, but what wasn't normal was the splat that I got after: WARNING: CPU: 7 PID: 176 at drivers/regulator/core.c:2151 _regulator_put+0x150/0x158 pc : _regulator_put+0x150/0x158 ... Call trace: _regulator_put+0x150/0x158 regulator_bulk_free+0x48/0x70 devm_regulator_bulk_release+0x20/0x2c release_nodes+0x1cc/0x244 devres_release_all+0x44/0x60 really_probe+0x17c/0x378 ... This is because the error paths don't turn off the regulator. Let's fix that. Fixes: 0ddce71c21f0 ("ASoC: rt5682: add rt5682 codec driver") Fixes: 87b42abae99d ("ASoC: rt5682: Implement remove callback") Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20210811081751.v2.1.I4a1d9aa5d99e05aeee15c2768db600158d76cab8@changeid Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sh/Makefile')
0 files changed, 0 insertions, 0 deletions