diff options
| author | Meng Tang <tangmeng@uniontech.com> | 2022-03-03 16:02:06 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2022-03-15 02:18:57 +0100 |
| commit | de845036f997119bcacbdb7b4ccf3b6cf960745b (patch) | |
| tree | b9e4a0f7e3d3eae63baa43ff41a7ab41876efac4 /drivers/pinctrl/berlin | |
| parent | c0e4c71a9e7ceea8f14e0b875fcc23266caf05e6 (diff) | |
| download | linux-de845036f997119bcacbdb7b4ccf3b6cf960745b.tar.gz | |
pinctrl: berlin: fix error return code of berlin_pinctrl_build_state()
When krealloc() fails and pctrl->functions is NULL, no error
return code of berlin_pinctrl_build_state() is assigned.
To fix this bug, ret is assigned with -ENOMEM when pctrl->functions
is NULL.
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Link: https://lore.kernel.org/r/20220303080206.16463-1-tangmeng@uniontech.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/berlin')
| -rw-r--r-- | drivers/pinctrl/berlin/berlin.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c index b17a03cf87be..a073eedd71aa 100644 --- a/drivers/pinctrl/berlin/berlin.c +++ b/drivers/pinctrl/berlin/berlin.c @@ -233,6 +233,8 @@ static int berlin_pinctrl_build_state(struct platform_device *pdev) pctrl->functions = krealloc(pctrl->functions, pctrl->nfunctions * sizeof(*pctrl->functions), GFP_KERNEL); + if (!pctrl->functions) + return -ENOMEM; /* map functions to theirs groups */ for (i = 0; i < pctrl->desc->ngroups; i++) { |