diff options
| author | Nick Bowler <nbowler@draconx.ca> | 2022-07-20 23:57:35 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-08-02 17:22:48 -0600 |
| commit | a25d4261582cf00dad884c194d21084836663d3d (patch) | |
| tree | 0d2cbf8a50c6bd3a0ccf35d74a4b08bac6b71ed9 /drivers/nvme/common | |
| parent | eb7e2d92588cc6351286de13e3b5d70ecc768888 (diff) | |
| download | linux-a25d4261582cf00dad884c194d21084836663d3d.tar.gz | |
nvme: define compat_ioctl again to unbreak 32-bit userspace.
Commit 89b3d6e60550 ("nvme: simplify the compat ioctl handling") removed
the initialization of compat_ioctl from the nvme block_device_operations
structures.
Presumably the expectation was that 32-bit ioctls would be directed
through the regular handler but this is not the case: failing to assign
.compat_ioctl actually means that the compat case is disabled entirely,
and any attempt to submit nvme ioctls from 32-bit userspace fails
outright with -ENOTTY.
For example:
% smartctl -x /dev/nvme0n1
[...]
Read NVMe Identify Controller failed: NVME_IOCTL_ADMIN_CMD: Inappropriate ioctl for device
The blkdev_compat_ptr_ioctl helper can be used to direct compat calls
through the main ioctl handler and makes things work again.
Fixes: 89b3d6e60550 ("nvme: simplify the compat ioctl handling")
Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Reviewed-by: Guixin Liu <kanie@linux.alibaba.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme/common')
0 files changed, 0 insertions, 0 deletions