diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2019-03-11 20:24:46 -0700 |
|---|---|---|
| committer | Deepak Rawat <drawat@vmware.com> | 2019-04-08 10:29:05 -0700 |
| commit | a5020f4f537ff1a0b73ea4eb78be185c34b261ae (patch) | |
| tree | b728d7813277af77d18b04f7ab69b22820486010 /drivers/gpu/drm/vmwgfx | |
| parent | 11c454196610ae25784ac19dc3f886a4328007e4 (diff) | |
| download | linux-a5020f4f537ff1a0b73ea4eb78be185c34b261ae.tar.gz | |
drm/vmwgfx: Zero initialize handle in vmw_execbuf_process
When building with -Wsometimes-uninitialized, Clang warns:
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3964:7: warning: variable
'handle' is used uninitialized whenever '?:' condition is false
[-Wsometimes-uninitialized]
It's not wrong; however, in practice, this is never an issue because
the value of handle isn't used when user_fence_rep is NULL because
vmw_execbuf_copy_fence_user returns immediately when that is the case.
Just zero initialize this variable so that Clang no longer warns.
Link: https://github.com/ClangBuiltLinux/linux/issues/397
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Deepak Rawat <drawat@vmware.com>
Diffstat (limited to 'drivers/gpu/drm/vmwgfx')
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index 6cc9837b10ec..2ff7ba04d8c8 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -3620,7 +3620,7 @@ int vmw_execbuf_process(struct drm_file *file_priv, struct vmw_sw_context *sw_context = &dev_priv->ctx; struct vmw_fence_obj *fence = NULL; struct vmw_cmdbuf_header *header; - uint32_t handle; + uint32_t handle = 0; int ret; int32_t out_fence_fd = -1; struct sync_file *sync_file = NULL; |