diff options
| author | Kemeng Shi <shikemeng@huawei.com> | 2022-12-05 19:57:07 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-12-05 13:45:05 -0700 |
| commit | e3031d4c7d2c5bff6b5944d61d4e31319739d216 (patch) | |
| tree | a00db9628c562714e147557e81b286396eccbf72 | |
| parent | 009df341714c6c20a44dd9268681a8bff10bb050 (diff) | |
| download | linux-e3031d4c7d2c5bff6b5944d61d4e31319739d216.tar.gz | |
blk-throttle: remove incorrect comment for tg_last_low_overflow_time
Function tg_last_low_overflow_time is called with intermediate node as
following:
throtl_hierarchy_can_downgrade
throtl_tg_can_downgrade
tg_last_low_overflow_time
throtl_hierarchy_can_upgrade
throtl_tg_can_upgrade
tg_last_low_overflow_time
throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse
from leaf node to sub-root node and pass traversed intermediate node
to tg_last_low_overflow_time.
No such limit could be found from context and implementation of
tg_last_low_overflow_time, so remove this limit in comment.
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
Link: https://lore.kernel.org/r/20221205115709.251489-8-shikemeng@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-throttle.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 7db8592dae38..e6a087de414d 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1762,7 +1762,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq; |