diff options
| author | Stefan Wahren <stefan.wahren@i2se.com> | 2022-06-25 10:36:43 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-08-22 19:17:12 -0700 |
| commit | 35f73cca1cecda0c1f8bb7d8be4ce5cd2d46ae8c (patch) | |
| tree | ce47b90a5119c06c1401e342e5c36c73ff238527 | |
| parent | 4b592061f7b3971c70e8b72fc42aaead47c24701 (diff) | |
| download | linux-35f73cca1cecda0c1f8bb7d8be4ce5cd2d46ae8c.tar.gz | |
clk: bcm: rpi: Fix error handling of raspberrypi_fw_get_rate
The function raspberrypi_fw_get_rate (e.g. used for the recalc_rate
hook) can fail to get the clock rate from the firmware. In this case
we cannot return a signed error value, which would be casted to
unsigned long. Fix this by returning 0 instead.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/20220625083643.4012-1-stefan.wahren@i2se.com
Fixes: 4e85e535e6cc ("clk: bcm283x: add driver interfacing with Raspberry Pi's firmware")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/bcm/clk-raspberrypi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 73518009a0f2..39d63c983d62 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -203,7 +203,7 @@ static unsigned long raspberrypi_fw_get_rate(struct clk_hw *hw, ret = raspberrypi_clock_property(rpi->firmware, data, RPI_FIRMWARE_GET_CLOCK_RATE, &val); if (ret) - return ret; + return 0; return val; } |