diff options
author | Peter Krempa <pkrempa@redhat.com> | 2023-05-15 12:17:06 +0200 |
---|---|---|
committer | Peter Krempa <pkrempa@redhat.com> | 2023-05-16 10:26:33 +0200 |
commit | de48ade19586fda704d4f517ffb219960c3d6a08 (patch) | |
tree | 7263c1c35b0498bd523608934ee9acccfc87d2a5 | |
parent | a091edf9db5d6e949190d9ea6ad384570c30def0 (diff) | |
download | libvirt-de48ade19586fda704d4f517ffb219960c3d6a08.tar.gz |
virDomainBackupDefAssignStore: Restructure control flow
Return early for errors instead of using 'else' branches.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/conf/backup_conf.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 4a8c05dca9..013c08cd6e 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -422,17 +422,19 @@ virDomainBackupDefAssignStore(virDomainBackupDiskDef *disk, _("disk '%1$s' has no media"), disk->name); return -1; } - } else if (!disk->store) { - if (virStorageSourceGetActualType(src) == VIR_STORAGE_TYPE_FILE) { - disk->store = virStorageSourceNew(); - disk->store->type = VIR_STORAGE_TYPE_FILE; - disk->store->path = g_strdup_printf("%s.%s", src->path, suffix); - } else { + } + + if (!disk->store) { + if (virStorageSourceGetActualType(src) != VIR_STORAGE_TYPE_FILE) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("refusing to generate file name for disk '%1$s'"), disk->name); return -1; } + + disk->store = virStorageSourceNew(); + disk->store->type = VIR_STORAGE_TYPE_FILE; + disk->store->path = g_strdup_printf("%s.%s", src->path, suffix); } return 0; |