diff options
| author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
|---|---|---|
| committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 09:59:40 +0200 |
| commit | 4ce590b007d80b41abd00aba95f73c04e71ff53b (patch) | |
| tree | 6c2e7718249725af5031cecbd25683c48998c2f4 | |
| parent | 1813138f6b00058285e325191d50c41ace39e5b3 (diff) | |
| download | libvirt-v4.2-maint.tar.gz | |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv4.2-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
| -rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 5b7c997b6f..22972979e7 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11216,6 +11216,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |