diff options
author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
---|---|---|
committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:03:12 +0200 |
commit | e322b6f73dc2fb5eaab14406cc786361d17ffdc3 (patch) | |
tree | b1d88ae5b2499c6b7bcf3553eb3d36ebb650d5f9 | |
parent | dea40b42188e883c4118b02527f5c02a6fbbac59 (diff) | |
download | libvirt-v2.1-maint.tar.gz |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv2.1-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index c85deda59c..6f40111b1a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11314,6 +11314,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |