diff options
author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
---|---|---|
committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:22:01 +0200 |
commit | ab728b5658b307bcde90cf9e9d2e9c2cfb3e9de0 (patch) | |
tree | 028f4c01c7dd042d0eba5fc9db3b1f3284d7cbdb | |
parent | a8ae178438be285b91c4871251ad1482c4e396df (diff) | |
download | libvirt-v1.3.4-maint.tar.gz |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv1.3.4-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index bef68a415e..27f92be5c7 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11309,6 +11309,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |