diff options
| author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
|---|---|---|
| committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:25:26 +0200 |
| commit | a663e28410aa853675b8b090a1ffafa7c8711ead (patch) | |
| tree | 5bcea5ab43b9b26459f881f5e1bfeb834fc63006 | |
| parent | b22baef31258621b3bdb5036a84772bc6b6ec0a4 (diff) | |
| download | libvirt-v1.3.3-maint.tar.gz | |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv1.3.3-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
| -rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index b903ebe5bc..26eead00db 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11303,6 +11303,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |