diff options
author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
---|---|---|
committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:26:31 +0200 |
commit | badcb3662a5b28d3ed01c8ceff496e6197d12e3c (patch) | |
tree | 62dd23a6e14e008151ebadd70d568fa78dadf226 | |
parent | fa2016e751452163aa2e93baa6c9bfc239e31885 (diff) | |
download | libvirt-v1.2.21-maint.tar.gz |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv1.2.21-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 461f7eb46d..7b69cfb431 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11082,6 +11082,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |