diff options
author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
---|---|---|
committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:26:30 +0200 |
commit | c5cc88c32320d46f27521aac69027baa3d426ff2 (patch) | |
tree | b272433ff06c91bcfc253106ddc951e8407d3d26 | |
parent | 99ac102b8310adf50d16b62c533405eee6544cf2 (diff) | |
download | libvirt-v1.2.20-maint.tar.gz |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv1.2.20-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 0303da6b04..b8e9e1e473 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11118,6 +11118,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |